Skip to content

[agent] best-effort interpretation and questions for vague asks - #536

Merged
r4yharris-agent-coder[bot] merged 1 commit into
mainfrom
agents/ask-clarify-assumptions-2
Oct 11, 2026
Merged

r4yharris-agent-coder[bot] merged 1 commit into
mainfrom
agents/ask-clarify-assumptions-2

Conversation

@r4yharris-agent-coder

Copy link
Copy Markdown
Contributor

feat(ask): best-effort interpretation and questions for vague asks

Model

GPT-6.1-Sol

Summary

A clarify Ask no longer dead-ends: roster ask, the shell and builtin runs print a deterministic offline best-effort reading, stated assumptions, up to three clarifying questions and a ready-to-fill template. No file, issue, seat or publication is created and no allow-list is invented; execution keeps its scope gate. Spec: 3 (stop early), 5.3 (allow-list stays human-declared), 5.7 (human interface); 7 respected (no new board). Supersedes #534 (CI test fixed).

Verification

13 test files mentioning clarify/Ask kind: 174 pass.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

AI-Agent: r4yharris-agent-coder
AI-Model: GPT-6.1-Sol

1|github-copilot|GPT-6.1-Sol@-|x|-/1000000|-|ghcp-20261011-109116|ask-clarify-assumptions-2

## Model
GPT-6.1-Sol

## Summary
A clarify Ask no longer dead-ends: roster ask, the shell and builtin runs print a deterministic offline best-effort reading, stated assumptions, up to three clarifying questions and a ready-to-fill template. No file, issue, seat or publication is created and no allow-list is invented; execution keeps its scope gate. Spec: 3 (stop early), 5.3 (allow-list stays human-declared), 5.7 (human interface); 7 respected (no new board). Supersedes #534 (CI test fixed).

## Verification
13 test files mentioning clarify/Ask kind: 174 pass.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

AI-Agent: r4yharris-agent-coder
AI-Model: GPT-6.1-Sol
AI-Run: 1|github-copilot|GPT-6.1-Sol@-|x|-/1000000|-|ghcp-20261011-109116|ask-clarify-assumptions-2
@r4yharris-agent-coder
r4yharris-agent-coder Bot marked this pull request as ready for review October 11, 2026 20:02
@r4yharris-agent-coder
r4yharris-agent-coder Bot merged commit b837f79 into main Oct 11, 2026
2 checks passed
@r4yharris-agent-coder
r4yharris-agent-coder Bot deleted the agents/ask-clarify-assumptions-2 branch October 11, 2026 20:03
r4yharris-agent-coder Bot added a commit that referenced this pull request Oct 11, 2026
feat(intake): persist private clarification checkpoints and resume safely

## Model
GPT-6.1-Sol

## Summary
Follow-up to #536 for #473: persist the original redacted Ask, bounded interpretation/questions and validated explicit follow-up scope in existing project ask storage. CLI --pending/--resume/--cancel and shell /clarify inspect, resume or cancel across restart. Resume supplements original constraints and retains normal scope/policy/review gates; the shell always pauses at --confirm before implementation. Cancel revokes prepared Enter/retry authority. No second board, speculative implementation, confidence scores or silent constraint overrides.

Spec: 5.7 human interface and 5.8 recovery/checkpoints, with 3 authority/stop-early and 7 no side-board honored. No vendor, policy, workflow or FEATURE_SPEC edits.

## Verification
Node 20 targeted tests: 14 clarification-related files, 184 passing (including CLI subprocess/offline draft, streaming shell restart/confirmation/cancel, malformed UTF-8/schema, symlink/hardlink, private/unignored/tracked storage, configured-key redaction and unsafe scope). Test file 254 lines. git diff --check clean.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

AI-Agent: r4yharris-agent-coder
AI-Model: GPT-6.1-Sol
AI-Run: 1|github-copilot|GPT-6.1-Sol@-|x|-/1000000|-|ghcp-20261011-107116|clarification-checkpoint
r4yharris-agent-coder Bot added a commit that referenced this pull request Oct 11, 2026
…iliation

docs: reconcile Eve architecture and carry-forward evidence

## Model
GPT-6.1-Sol

## Summary
Audit documented architecture against source and reconcile #473/#489 carry-forward obligations. Cite FEATURE_SPEC sections 5.1–5.8; honor principles 3, exclusions 7 and acceptance 8. Distinguish implemented foundations, actual reproduced defects, merged #536/#539/#540/#541 repairs, partial capabilities, human gates and workflow/contracts ownership. Preserve historical failure evidence and retained candidate trees; no acceptance fabrication or installed-checkout mutation.

## Verification
Documentation-only final change; git diff --check. Audit component tests: 152/152 targeted Windows Node20 pass. Related merged repairs: #539 184/184; #540 74 pass/two existing skips; #541 160/160 plus 35/35 after rebase, all merged App CI. Full local suite intentionally not rerun; human acceptance remains open.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

AI-Agent: r4yharris-agent-coder
AI-Model: GPT-6.1-Sol
AI-Run: 1|github-copilot|GPT-6.1-Sol@-|x|-/1000000|-|ghcp-20261011-78892|eve-architecture-reconciliation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants