Repository navigation
[agent] count dynamically imported app code in the coder test-substance gate - #533
Merged
Merged
Conversation
…gate
## Model
GPT-6.1-Sol
## Summary
- FEATURE_SPEC 5.3: the repeat live medium M3 run burned its 20-minute budget because the excellence gate flagged every parse-csv test as "never calls imported app code". The tests called parseCsv, bound by `const { parseCsv } = await import(pathToFileURL(...))`, which the gate did not recognise (it read only static imports), so the coder was sent through repeated repair passes for passing, meaningful tests.
- parseImports now treats `const|let|var <binding> = await import(<non-builtin>)` as an app import, including expression specifiers and destructured renames. Built-in and harness specifiers are still excluded, and a test that asserts only on values it built is still flagged.
## Verification
- Node 20: test-substance and excellence suites pass (37); the new test fails without the change.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
AI-Agent: r4yharris-agent-coder
AI-Model: GPT-6.1-Sol
AI-Run: 1|github-copilot|GPT-6.1-Sol@-|x|-/1000000|-|ghcp-20261011-76124|substance-dynamic-import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: count dynamically imported app code in the coder test-substance gate
Model
GPT-6.1-Sol
Summary
const { parseCsv } = await import(pathToFileURL(...)), which the gate did not recognise (it read only static imports), so the coder was sent through repeated repair passes for passing, meaningful tests.const|let|var <binding> = await import(<non-builtin>)as an app import, including expression specifiers and destructured renames. Built-in and harness specifiers are still excluded, and a test that asserts only on values it built is still flagged.Verification
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com
AI-Agent: r4yharris-agent-coder
AI-Model: GPT-6.1-Sol
1|github-copilot|GPT-6.1-Sol@-|x|-/1000000|-|ghcp-20261011-76124|substance-dynamic-import