Conversation
The logo is an upscaled (using nearest-neighbor) version of `src/main/resources/img/icon.png` Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
| @@ -0,0 +1,11 @@ | |||
| [Desktop Entry] | |||
| Categories=Game;Utility;GameTool;Java; | |||
There was a problem hiding this comment.
| Categories=Game;Utility;GameTool;Java; | |
| Categories=Game;GameTool;Java; |
Utility is a general system tool or a tool that does a simple operation without a specificity defined goal.
It is not a Utility if it was a GameTool.
Also, recommendation is against having more than one main category, in this case both Utility and Game.
| @@ -0,0 +1,11 @@ | |||
| [Desktop Entry] | |||
| Categories=Game;Utility;GameTool;Java; | |||
| Comment=Tool to select chunks from Minecraft worlds for deletion or export | |||
There was a problem hiding this comment.
| Comment=Tool to select chunks from Minecraft worlds for deletion or export | |
| Comment=Select, edit, and export chunks of your Minecraft world |
| [Desktop Entry] | ||
| Categories=Game;Utility;GameTool;Java; | ||
| Comment=Tool to select chunks from Minecraft worlds for deletion or export | ||
| Exec=@binary@ |
There was a problem hiding this comment.
I can't see any build system that will replace this here. Should we just not include it or keep it empty?
Later in any packaging solution we can just run:
$ desktop-file-edit --set-key=Exec --set-value="mcaselector" <desktop file>
or something smilier, depending on the launcher used
| Type=Application | ||
| Version=1.0 |
There was a problem hiding this comment.
It would be easier to read if those were moved to the top.
Just like the order they are defined at https://specifications.freedesktop.org/desktop-entry-spec/latest/recognized-keys.html
| Comment=Tool to select chunks from Minecraft worlds for deletion or export | ||
| Exec=@binary@ | ||
| Icon=net.querz.mcaselector | ||
| Name=MCA Selector |
There was a problem hiding this comment.
| Name=MCA Selector | |
| Name=MCA Selector | |
| GenericName=Minecraft Chunks Manager | |
| Keywords=filter;select;delete;import;NBT; |
|
Wouldn't it be better to have the desktop file under |
This PR adds a high quality version of the logo (512x512, scaled using nearest neighbor) and a preset .desktop file for Linux packages.
I intend to use this for the Nixpkgs/NixOS package as requested in NixOS/nixpkgs#428016