feat(code-assistant): add lifespan for httpx client lifecycle management#198
Merged
feat(code-assistant): add lifespan for httpx client lifecycle management#198
Conversation
Replace the fragile atexit-based cleanup with a proper FastMCP lifespan context manager that creates the httpx.AsyncClient on startup and closes it on shutdown, preventing resource leaks and ResourceWarning. Closes #197 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
# Conflicts: # qiskit-code-assistant-mcp-server/src/qiskit_code_assistant_mcp_server/server.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asynclifespan context manager that creates thehttpx.AsyncClienton server startup and properly closes it on shutdownFastMCP()via thelifespanparameterset_http_client()/clear_http_client()toutils.pyfor proper client injectionatexit-based cleanup from__main___clientdirectlyMirrors the approach from #176 for the docs server. Prevents resource leaks and
ResourceWarningfor unclosed connections.Closes #197