Nexus: Rework nexus_core, nexus_noncore, and nexus_core_noncore - #6207
Open
brockdyer03 wants to merge 2 commits into
Open
Nexus: Rework nexus_core, nexus_noncore, and nexus_core_noncore#6207brockdyer03 wants to merge 2 commits into
nexus_core, nexus_noncore, and nexus_core_noncore#6207brockdyer03 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR collects the disparate config settings from the three
objinnexus_base.py,nexus_core,nexus_noncore, andnexus_core_noncore, and puts them into a single class with defined types, methods, and documentation.Additionally, it converts
status_modesinto the new enumShowStatusModeand collectsmodesinto the enumSimStage.Additionally, it deprecates some of the previous attributes described in #6198 and issues warnings that guide users on how to replace them.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
Laptop, Fedora Linux 44 (KDE Plasma Desktop Edition)
AMD Ryzen 7 PRO 7840U (8 cores, 16 logical processors)
Checklist