misc cleanup: skip flaky test_values, fix dup-doc warning, ignore artifacts#688
Merged
Conversation
…ifacts Three small loose ends bundled into one PR. * mpisppy/tests/test_admmWrapper.py, mpisppy/tests/test_stoch_admmWrapper.py: test_values in both files fails when run via pytest's subprocess capture (returncode=1, empty stdout AND stderr) but works identically when launched from a bare Python script or shell. The subprocess seems to die before producing any output — likely a pytest stdio-capture / file-descriptor interaction with Open MPI's I/O forwarding. Mark both tests with @unittest.skip and a clear reason pointing at the example bash scripts as the manual workaround until the root cause is diagnosed. * doc/src/generic_admm.rst: the file documents consensus_vars_creator twice (once for --admm, once for --stoch-admm), which produced a Sphinx "duplicate object description" warning. Add :no-index: to the --stoch-admm directive so only one ends up in the index. * .gitignore: add conservative patterns for mpi-sppy runtime artifacts that have been accumulating untracked in many users' working trees — per-rank iteration summaries, _delme*/delete_me* scratch dirs, specific.csv_* exports, example output files (ef.txt, hub.log, solution_*.txt, *_full_solution/, *_pickles/, *_cyl_nonants.npy). Leaves ambiguous patterns (e.g., archive/, CI/, *.perf.csv) untouched. Tests: 42 passed, 2 skipped (the two test_values). Doc build: 4 warnings -> 3 warnings (dup-description warning gone). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
6 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #688 +/- ##
==========================================
- Coverage 71.04% 70.78% -0.26%
==========================================
Files 154 154
Lines 19252 19252
==========================================
- Hits 13678 13628 -50
- Misses 5574 5624 +50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mkhraijah
pushed a commit
to mkhraijah/mpi-sppy
that referenced
this pull request
May 14, 2026
…ifacts (Pyomo#688) Three small loose ends bundled into one PR. * mpisppy/tests/test_admmWrapper.py, mpisppy/tests/test_stoch_admmWrapper.py: test_values in both files fails when run via pytest's subprocess capture (returncode=1, empty stdout AND stderr) but works identically when launched from a bare Python script or shell. The subprocess seems to die before producing any output — likely a pytest stdio-capture / file-descriptor interaction with Open MPI's I/O forwarding. Mark both tests with @unittest.skip and a clear reason pointing at the example bash scripts as the manual workaround until the root cause is diagnosed. * doc/src/generic_admm.rst: the file documents consensus_vars_creator twice (once for --admm, once for --stoch-admm), which produced a Sphinx "duplicate object description" warning. Add :no-index: to the --stoch-admm directive so only one ends up in the index. * .gitignore: add conservative patterns for mpi-sppy runtime artifacts that have been accumulating untracked in many users' working trees — per-rank iteration summaries, _delme*/delete_me* scratch dirs, specific.csv_* exports, example output files (ef.txt, hub.log, solution_*.txt, *_full_solution/, *_pickles/, *_cyl_nonants.npy). Leaves ambiguous patterns (e.g., archive/, CI/, *.perf.csv) untouched. Tests: 42 passed, 2 skipped (the two test_values). Doc build: 4 warnings -> 3 warnings (dup-description warning gone). Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three pre-existing loose ends bundled into one cleanup PR. Independent of #686 (phase A hooks) and #687 (distr example cleanup).
test_valuesflaky under pytest —mpisppy/tests/test_admmWrapper.py::test_valuesandmpisppy/tests/test_stoch_admmWrapper.py::test_valuesboth fail withreturncode=1, stdout='', stderr=''when run via pytest'ssubprocess.run(..., capture_output=True). The exact samempiexeccommand works in 0.5s from a bare Python script or shell (verified directly). Likely a pytest stdio-capture / fd interaction with Open MPI's I/O forwarding; full diagnosis is out of scope. Mark both with@unittest.skipand a clear reason pointing at the correspondingexamples/*/go.bashas the manual workaround.Duplicate
consensus_vars_creatordoc warning —doc/src/generic_admm.rstdocuments the function twice (once for--admm, once for--stoch-admm), producing a "duplicate object description" warning on every doc build. Add:no-index:to the--stoch-admmdirective so only one entry ends up in the Python object index. Doc build now shows 3 warnings instead of 4..gitignorefor runtime artifacts — many user working trees accumulate untracked files from running examples: per-rank iteration summaries (*_summary_iter*_rank*.txt),_delme*/delete_me*scratch dirs,specific.csv_*exports, and per-example output files (ef.txt,hub.log,solution_*.txt,*_full_solution/,*_pickles/,*_cyl_nonants.npy). Add conservative patterns; leave ambiguous ones alone (archive/,CI/,*.perf.csvat examples root). Drops the local untracked count from ~29 to ~9.Test plan
python -m pytest mpisppy/tests/test_admmWrapper.py mpisppy/tests/test_stoch_admmWrapper.py mpisppy/tests/test_admm_bundler.py— 42 passed, 2 skipped (bothtest_values)cd doc && make html— 3 warnings (was 4); remaining ones are unrelated pre-existing (viewcode config, autosummary log, uc_cleanup toctree)go.bashpaths still exercise the same code paths the skipped tests would)🤖 Generated with Claude Code