-
Notifications
You must be signed in to change notification settings - Fork 80
refactor(int32): per-model label dtype instead of sticky process-global #828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
129d119
perf(int32): auto-widen labels to int64 on overflow instead of raising
FabianHofmann 067fd2a
perf(int32): re-widen label dtype when loading an int64 model
FabianHofmann d338858
perf(int32): warn on auto-widen, recommend explicit int64 for large m…
FabianHofmann 15b6a2f
test(int32): add type annotations to auto-widen tests for mypy
FabianHofmann e215297
chore: trigger CI
FBumann 163ddb3
refactor(int32): make label-dtype widening per-model instead of proce…
FBumann d4cf445
feat(int32): accept label_dtype as Model() argument
FBumann f7323af
refactor: deduplicate label allocation and dtype validation
FBumann aaecbf6
docs: trim label-dtype release note to user-facing behavior
FBumann 70ec680
refactor!: drop linopy.options['label_dtype'] in favor of the Model()…
FBumann 5d61e9c
refactor(int32): expose per-model dtypes as a read-only mapping
FBumann 2fd1c8d
refactor(int32): store per-model dtypes in a single _dtypes dict
FBumann f64d1bf
refactor(int32): extract dtypes validation into _resolve_dtypes helper
FBumann cc1252b
style(int32): drop Sphinx comment on DtypeKey alias
FBumann e63d92b
docs(int32): trim dtypes docstrings and release note
FBumann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should only be true if dtype!=int64