Repository navigation
mypy: type-check tests and use pathlib fixtures - #2685
Merged
DanielNoord merged 1 commit intoSep 27, 2026
Merged
Conversation
DanielNoord
force-pushed
the
agents/remove-mypy-overrides-fix-errors
branch
from
September 27, 2026 15:16
c7aee1d to
14ef25c
Compare
DanielNoord
force-pushed
the
agents/remove-mypy-overrides-fix-errors
branch
from
September 27, 2026 15:18
14ef25c to
a64712a
Compare
DanielNoord
marked this pull request as ready for review
September 27, 2026 15:19
DanielNoord
enabled auto-merge
September 27, 2026 15:20
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2685 +/- ##
==========================================
- Coverage 99.44% 99.41% -0.04%
==========================================
Files 41 41
Lines 3231 3231
Branches 690 690
==========================================
- Hits 3213 3212 -1
- Misses 11 12 +1
Partials 7 7 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tmpdir/tmpdir_factoryfixtures and path operations with typedtmp_path/tmp_path_factoryandpathlibAPIs.Validation
uv run mypypasses (86 source files).uv run python -m compileall -q isort testspasses.uv run pytest tests/unit: 621 passed, 1 skipped, 1 failed. The existingtest_isort_can_turn_off_import_adds_with_action_comment_issue_1737failure expects atyping.Anyimport absent from the actual output.This pull request is intentionally kept as a draft.