Stop configuration discovery at Git worktree boundaries - #2654
Open
vzer200 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Git worktree has no local isort configuration, its
.gitfile is ignored during configuration discovery. An outer.isort.cfgcan then be inherited, changing the source paths and classifying a local module as third party. Stop discovery at.gitfiles as well as directories, while retaining local config precedence and the existing Mercurial boundary behavior.Addresses the reproduced outer-configuration case of #2068. This does not establish the cause of every worktree classification problem in that report.
Validation on Windows with Python 3.12:
os.mkfifotyping, the existing CRLF formatting fixture, and Bandit's assertion finding inparse.py:407.Other Python/OS runtimes, mypyc builds and the network-cloning integration suite were not run.
AI disclosure: developed and independently reviewed by Codex agents on behalf of vzer200; no human line-by-line review is claimed.