Add particle data to particles - #2279
Closed
neeleshpoli wants to merge 5 commits into
Closed
Conversation
- Changed the visibility of `get_world_res` from private to super. - Removed the `spawn_particle` method from `World` to streamline the interface for plugins. Generate a new spawn function for each particle for plugins to spawn functions. - Updated the `spawn_particle` method in `World` to accept a generic particle type that implements `SerializeParticleData`. - Adjusted particle spawning logic to use the new generic approach, ensuring compatibility with different particle types.
This was referenced Jun 17, 2026
Contributor
Author
|
Ok didn't realize that I actually didn't need to create the PR for the wit-types repo, will close that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds data fields to the particles, using automatically generated code with
pumpkin-codegen. A struct is created for each particle, and they all implementSerializeParticleDatatrait.Changes (in this repository)
pumpkin-codegento generate structs for each particle and respectiveSerializeParticleDataimplementationParticlesenum to use the new generated structsTesting
I didn't add any tests, but I performed manual testing:
Companion PR
This is the PR for the extractor changes.