164 consider dynamic values for scotland hub figures - #237
Open
laurenmacarthur wants to merge 9 commits into
Open
164 consider dynamic values for scotland hub figures#237laurenmacarthur wants to merge 9 commits into
laurenmacarthur wants to merge 9 commits into
Conversation
…onment instead of from excel file
…nvironment instead of from excel file
sarahtaws
requested changes
Aug 17, 2026
sarahtaws
left a comment
sarahtaws
left a comment
Contributor
There was a problem hiding this comment.
Fab work, thank you Lauren!
Couple things:
- EF1 needs a comma
- EF2, EF4, EQ4 need the space before % removed
- E1 & EF4 missing "(In financial year 20XX/XX)"
- Efficient boxes are not linear - fix this but also see if possible to have all boxes be the same size across all indicators?
To discuss:
- Irregularity with timeframes and grammar in brackets, e.g. (calendar year) vs (In calendar year 2024), (In financial year 2025/26), (2026 Q1) vs (Jan-Mar 2026) vs (Q4 2025/26)
app: new package required for comma
…ile. infographic ui: add text instead of pulling from excel file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.