Skip to content

Fix item drops sometimes being rejected #3295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lost-werewolf wants to merge 1 commit into
base: general-devel
Choose a base branch
from
Open

Fix item drops sometimes being rejected #3295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion TShockAPI/Bouncer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1249,7 +1249,8 @@ internal void OnItemDrop(object sender, GetDataHandlers.ItemDropEventArgs args)
}

// stop the client from changing the item type of a drop
if (Main.item[id].active && Main.item[id].type != type &&
// as long as it's not the last item
if (id < Main.maxItems && Main.item[id].active && Main.item[id].type != type &&
!(Main.item[id].type == ItemID.EmptyBucket && type == ItemID.WaterBucket)) // Empty bucket turns into Water Bucket on rainy days
{
TShock.Log.ConsoleDebug(GetString("Bouncer / OnItemDrop rejected from item drop check from {0}", args.Player.Name));
Expand Down
Loading