[Fix] Drop the Node when shutting down#4021
Merged
Merged
Conversation
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
This was referenced Nov 21, 2025
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
kaimast
approved these changes
Nov 24, 2025
kaimast
left a comment
kaimast
left a comment
Contributor
There was a problem hiding this comment.
Thanks. This is a great first step to clean up shutdown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a temporary solution that allows the
Nodeto drop correctly when it's being shut down. It's a successor to #4017, which is no longer needed.This will likely be superseded by #3915 in the future (as that one would also be able to support tests), but for regular node use, this should suffice.