chore(pass-desktop): add Flatpak desktop entry and AppStream metainfo#487
Draft
the-narwhal wants to merge 1 commit intoProtonMail:mainfrom
Draft
chore(pass-desktop): add Flatpak desktop entry and AppStream metainfo#487the-narwhal wants to merge 1 commit intoProtonMail:mainfrom
the-narwhal wants to merge 1 commit intoProtonMail:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Flatpak desktop entry and AppStream metainfo for Proton Pass desktop
What
Adds two files to
applications/pass-desktop/assets/:me.proton.Pass.desktop— XDG desktop entry for the Linux appme.proton.Pass.metainfo.xml— AppStream component metadata for Flathub/GNOME SoftwareWhy
The Flathub listing for Proton Pass (
me.proton.Pass) is being migratedfrom a binary
.debwrapper to a full build from source. Flathub'senhanced requirements mandate that GPL-licensed apps build from source.
Both files are currently carried as copies inside the Flathub manifest
repository. Having them here in the upstream source tree means:
How the files were derived
me.proton.Pass.desktop— all values taken directly fromforge.config.ts(MakerDeb/MakerRpm options:
productName,genericName,productDescription,categories,homepage) and the packager config (executableName,appBundleId).me.proton.Pass.metainfo.xml— written to theFlathub AppStream guidelines.
Description text is taken from the existing Proton Pass marketing copy.
Release notes are sourced from
CHANGELOG.md.Once merged
The
type: filesources in the Flathub manifest will be updated toreference these paths directly from the upstream git checkout, and the
local copies in the manifest repository will be removed.
Related Flathub PR: flathub/me.proton.Pass#99