Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Issue #484
Hi!
I'm Shreya, a CS student who's looking to contribute to open source projects. I'm a beginner, but I like to tinker around. I noticed the composer editor stays white in dark mode which felt like a hiccup in UX, so I decided to dig into it. My skillset also lies in design and i thought this was a UI bug that was making the UX a bit annoying.
I'll be honest - it took me a while to figure out what was going on. I started by searching for the editor styles, found the hardcoded 'background: white' in RoosterEditorIframe.raw.scss, and thought that was the fix. But changing it didn't work, which sent me down a rabbit hole.
I used Claude to help me what was going wrong and tried to fix it:
The composer loads in an iframe that's isolated from the parent page, so CSS variables from the theme don't just pass through automatically. After tracing through
useInitRooster.tsanduseSyncIframeStyles, I found thatproperties.tsonly syncs two CSS variables into the iframe. Adding--background-normto that list, along with changing the hardcodedwhitein the SCSS, seemed like the right fix.I can't fully run the app locally to verify it end to end, so I'd really appreciate your review. If I've missed something or approached this wrong, I'm happy to learn and fix it!
Thank you,
Shreya