Remove unnecessary ARIA attributes from WindowSideBarButtons#4269
Open
lhenze wants to merge 1 commit intoProjectMirador:mainfrom
Open
Remove unnecessary ARIA attributes from WindowSideBarButtons#4269lhenze wants to merge 1 commit intoProjectMirador:mainfrom
lhenze wants to merge 1 commit intoProjectMirador:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4269 +/- ##
=====================================
Coverage 93.0% 93.0%
=====================================
Files 335 335
Lines 5530 5530
Branches 1956 1956
=====================================
Hits 5141 5141
Misses 346 346
Partials 43 43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marlo-longley
approved these changes
Apr 9, 2026
Member
marlo-longley
left a comment
marlo-longley
left a comment
There was a problem hiding this comment.
Looks good to me; feel free to merge if desired during UX call.
Collaborator
Author
|
Thanks @marlo-longley ! Over to @brittnylapierre |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing Accessibility issue:
https://www.w3.org/WAI/WCAG22/Understanding/name-role-value.html
https://axe.deque.com/issues/54bf4280-088f-4415-ba90-46c7e42959fe
Fixes: #4268