Skip to content

Upgrade to vite 8#4260

Draft
jcoyne wants to merge 7 commits intomainfrom
vite8
Draft

Upgrade to vite 8#4260
jcoyne wants to merge 7 commits intomainfrom
vite8

Conversation

@jcoyne
Copy link
Copy Markdown
Collaborator

@jcoyne jcoyne commented Apr 1, 2026

No description provided.

@jcoyne jcoyne marked this pull request as draft April 1, 2026 15:10
@jcoyne jcoyne marked this pull request as draft April 1, 2026 15:10
@marlo-longley
Copy link
Copy Markdown
Member

@jcoyne Vite 8 removes esbuild support -- I'm working on this.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.1%. Comparing base (2fcc336) to head (06da401).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4260     +/-   ##
=======================================
+ Coverage   93.0%   93.1%   +0.2%     
=======================================
  Files        335     386     +51     
  Lines       5530    5720    +190     
  Branches    1956    1956             
=======================================
+ Hits        5141    5325    +184     
- Misses       346     348      +2     
- Partials      43      47      +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marlo-longley
Copy link
Copy Markdown
Member

marlo-longley commented Apr 1, 2026

Almost there but the Netlify preview is broken (no errors but the page is blank) -- something is wrong with the build or deploy

@marlo-longley
Copy link
Copy Markdown
Member

marlo-longley commented Apr 3, 2026

The build is also broken locally (running npm build, npm pack and using in mirador-integration is my flow for testing both ES and UMD builds)
I believe it is this issue: https://vite.dev/guide/migration#consistent-commonjs-interop but need more time to debug and test.

@geourjoa
Copy link
Copy Markdown
Collaborator

geourjoa commented Apr 3, 2026

Hello @marlo-longley

I just test your branch. I have no issue to run npm run build.

I clean my node modules and run npm i. No issue when running Mirador. I use Node 24 on Linux

Also I have tested inside mirador-integration (both serve and serve-umd) without issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants