Conversation
cbeer
force-pushed
the
monorepo
branch
7 times, most recently
from
ca997ac to
e608e99
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3984 +/- ##
=======================================
Coverage 94.52% 94.52%
=======================================
Files 313 313
Lines 14767 14767
Branches 2496 2496
=======================================
Hits 13958 13958
Misses 804 804
Partials 5 5 ☔ View full report in Codecov by Sentry. |
cbeer
force-pushed
the
monorepo
branch
4 times, most recently
from
9558482 to
6d507bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A monorepo (pulling in mirador, mirador-annotations, -image-tools, etc) may make it easier to develop and maintain core plugins. It may also make it easier to manage some of the core mirador components if we extract additional packages for e.g. the window, workspace, etc pieces with clearly defined boundaries between the different pieces.
TODOs: