add aria-selected and aria-expanded#3909
Open
fstoe wants to merge 2 commits intoProjectMirador:mainfrom
Open
Conversation
gerdesque
previously approved these changes
Jul 9, 2024
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3909 +/- ##
=======================================
Coverage 94.52% 94.52%
=======================================
Files 313 313
Lines 14767 14775 +8
Branches 2496 2497 +1
=======================================
+ Hits 13958 13966 +8
Misses 804 804
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gerdesque
approved these changes
Dec 19, 2024
lutzhelm
approved these changes
Feb 10, 2025
Contributor
lutzhelm
left a comment
lutzhelm
left a comment
There was a problem hiding this comment.
From my perspective, everything looks fine, but I'd like to invite some feedback from people who have more expertise around accessibility issues than me.
marlo-longley
moved this from Needs PR Review
to Needs Discussion
in Accessibility + UX
brittnylapierre
moved this from Needs Discussion
to Needs PR Review
in Accessibility + UX
Collaborator
|
Related #3907 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
this PR is for fixing missing aria-expanded and aria-selected labels as described in issue #3578 including (#3907)