Draft
Conversation
barmintor
force-pushed
the
issue-3789_auth2
branch
3 times, most recently
from
61326f2 to
2221286
Compare
…ne iiif images - jest specs for image service identification - jest specs for resource type filters - ProjectMirador#3789
- IIIF Auth2 services will be members of a probe service - ProjectMirador#3789
…3789) - DRY search routines into functions defined in getServices - all routines should look for Auth2 types and Auth1 profiles - include search for uncoducmented Auth1 implementation of explicit probe service
- correct a spec name in accessTokens.test.js - stop refetching accessTokens if state has an ok true/false attribute - ProjectMirador#3789
- src/state/sagas/auth.js - src/state/sagas/iiif.js - src/state/sagas/windows.js - src/state/selectors/auth.js - src/state/selectors/canvases.js
barmintor
force-pushed
the
issue-3789_auth2
branch
from
a6f2308 to
0231d8e
Compare
cbeer
reviewed
Nov 22, 2023
Comment on lines
+1
to
+27
| /** values for type/@type that indicate an image content resource */ | ||
| const imageTypes = ['Image', 'StillImage', 'dctypes:Image', 'dctypes:StillImage']; | ||
| Object.freeze(imageTypes); | ||
|
|
||
| /** values for type/@type that indicate a sound content resource */ | ||
| const audioTypes = ['Audio', 'Sound', 'dctypes:Audio', 'dctypes:Sound']; | ||
| Object.freeze(audioTypes); | ||
|
|
||
| /** values for type/@type that indicate a text content resource */ | ||
| const textTypes = ['Document', 'Text', 'dctypes:Document', 'dctypes:Text']; | ||
| Object.freeze(textTypes); | ||
|
|
||
| /** values for type/@type that indicate a video content resource */ | ||
| const videoTypes = ['Video', 'MovingImage', 'dctypes:Video', 'dctypes:MovingImage']; | ||
| Object.freeze(videoTypes); | ||
|
|
||
| /** values for profile that indicate an image service */ | ||
| const imageServiceProfiles = [ | ||
| 'level2', | ||
| 'level1', | ||
| 'level0', | ||
| 'http://iiif.io/api/image/2/level2.json', | ||
| 'http://iiif.io/api/image/2/level1.json', | ||
| 'http://iiif.io/api/image/2/level0.json', | ||
| ]; | ||
|
|
||
| Object.freeze(imageServiceProfiles); |
Collaborator
There was a problem hiding this comment.
I wonder if these could/should go into settings somewhere so downstream apps can customize them?
Collaborator
Author
There was a problem hiding this comment.
something similar to auth.serviceProfiles maybe?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cf #3789