Repository navigation
fix(planner): refuse roll-up plans in milp_output - #814
Merged
Merged
Conversation
sketch-bench#190 lets a deployment grouped by G_d serve a RAQE grouped by a subset G_r. aggregation_config takes the labels from the first RAQE a deployment serves, so such a plan would be written at whichever grouping came first, silently. Until the engine reads a deployment at a coarser grouping, plan_to_planner_output refuses a RAQE whose grouping differs from its deployment's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FhcWJExZcmVqS6r6rEtjis
milindsrivastava1997
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #813.
milp_output::aggregation_configtakes a deployment's labels from the first RAQE it serves. ProjectASAP/sketch-bench#190 lets a deployment grouped byG_dserve a RAQE grouped by a subsetG_r(a roll-up). With a roll-up plan, the configs would be written at whichever grouping came first, and nothing would error.asap-planner-rstracks sketch-benchmain, so this lands on the next lockfile update.Change
plan_to_planner_outputchecks every RAQE against its deployment.MilpOutputError::RollupUnsupported { query, raqe, deployment }, which names both label sets.aggregation_configdoc now states the invariant it relies on.Reading a deployment at a coarser grouping in the engine is a separate feature. This is the interface #190 asks for in the meantime.
Tests
rollup_is_refused: planssum by (job), widens its deployment to(instance, job), and expects the error. It fails without the check.cargo test -p asap_planner --lib optimizer::(66 passed),cargo clippy -p asap_planner --all-targets -D warningsandcargo fmt --checkpass. These ran on a CloudLab node, because the local machine lacks OpenSSL headers.The issue also records a check that came back clean:
MultipleIncreaseis always keyed per series, becausesum(rate)isn't collapsable and bareratekeeps every label.🤖 Generated with Claude Code
https://claude.ai/code/session_01FhcWJExZcmVqS6r6rEtjis