[codex] Fix translation popup interaction#170
Open
tyreseluo wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The translation entry point was still visible even when the feature was disabled, and the language picker popup had broken interaction behavior. Scrolling could move the room timeline behind the popup, and the popup could trap the rest of the room UI until a language was chosen.
Impact
Users now only see the realtime translation control when the feature is enabled, and the language picker behaves like a normal modal: it accepts clicks and scrolling itself, blocks background interaction, and closes when clicking outside.
Root Cause
The room input bar did not sync the translation button visibility with the persisted translation config. The room screen also did not treat the translation language modal as the active interactive layer, so popup and background events were not isolated correctly.
Validation