Skip to content

[codex] Fix translation popup interaction#170

Open
tyreseluo wants to merge 1 commit into
mainfrom
codex/fix-translation-popup-ux
Open

[codex] Fix translation popup interaction#170
tyreseluo wants to merge 1 commit into
mainfrom
codex/fix-translation-popup-ux

Conversation

@tyreseluo
Copy link
Copy Markdown

Summary

  • hide the room input realtime translation button when translation is disabled in settings
  • close stale translation UI state automatically when the translation feature is turned off
  • fix the room translation language popup so it can be dismissed by clicking outside and no longer leaks interaction to the timeline behind it

Why

The translation entry point was still visible even when the feature was disabled, and the language picker popup had broken interaction behavior. Scrolling could move the room timeline behind the popup, and the popup could trap the rest of the room UI until a language was chosen.

Impact

Users now only see the realtime translation control when the feature is enabled, and the language picker behaves like a normal modal: it accepts clicks and scrolling itself, blocks background interaction, and closes when clicking outside.

Root Cause

The room input bar did not sync the translation button visibility with the persisted translation config. The room screen also did not treat the translation language modal as the active interactive layer, so popup and background events were not isolated correctly.

Validation

  • cargo build
  • manual user verification of the translation button visibility and language popup behavior

@tyreseluo tyreseluo marked this pull request as ready for review June 1, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant