Adjust Okaidia Prism theme color for WCAG contrast compliance#4072
Open
Brennvo wants to merge 1 commit intoPrismJS:v2from
Open
Adjust Okaidia Prism theme color for WCAG contrast compliance#4072Brennvo wants to merge 1 commit intoPrismJS:v2from
Brennvo wants to merge 1 commit intoPrismJS:v2from
Conversation
Before (fails WCAG AA and AAA): * Background: `#272822` * Foreground: `#F92672` https://webaim.org/resources/contrastchecker/?fcolor=F92672&bcolor=272822 After (passes WCAG AA): * Background: `#272822` * Foreground: `#FF4F8F` https://webaim.org/resources/contrastchecker/?fcolor=FF4F8F&bcolor=272822
✅ Deploy Preview for dev-prismjs-com ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Okaida theme consists of a font color that fails WCAG AA and AAA for normal text. This PR adjusts the font color to meet WCAG AA.
Note
I would recommend striving for AAA, but that would cause the theme to change more drastically. I can update this PR if that is not a problem.
Before
Fails WCAG AA and AAA:
#272822#F92672https://webaim.org/resources/contrastchecker/?fcolor=F92672&bcolor=272822
After
Passes WCAG AA:
#272822#FF4F8Fhttps://webaim.org/resources/contrastchecker/?fcolor=FF4F8F&bcolor=272822