-
Notifications
You must be signed in to change notification settings - Fork 615
Inline raw multimodal images in the v1 train client #2120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
eligotts
wants to merge
19
commits into
main
Choose a base branch
from
feat/v1-inline-raw-images
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
173a518
Support raw image offload in v1 train client
eligotts de37650
Enforce strict raw multimodal descriptors
eligotts e6b13dc
Simplify v1 raw multimodal: drop the cache-miss retry subsystem
S1ro1 9430999
Merge remote-tracking branch 'origin/main' into codex/v1-raw-image-of…
eligotts 4a7b37a
feat: support inline multimodal images
eligotts 0b1d73f
Simplify v1 raw image offload path
eligotts 2d4969b
Preserve v1 node usage in trace dumps
eligotts 7ade0b2
Surface request preparation failures on traces
eligotts 0dc57a1
Require raw image URIs in v1 sidecars
eligotts 18b0fbe
Share multimodal image preparation across clients
eligotts 22c7cf4
Merge remote-tracking branch 'origin/main' into codex/v1-raw-image-of…
eligotts 9b3e7ee
Merge remote-tracking branch 'origin/main' into codex/v1-raw-image-of…
eligotts 2c2824a
Cover every image part shape at multimodal ingress
eligotts 9bc3cc3
Merge commit '5885ab9c54' into codex/v1-raw-image-offload
eligotts 2b1627d
Merge remote-tracking branch 'origin/main' into codex/v1-raw-image-of…
eligotts 3d2068b
Drop the orphaned prepare_messages client hook
eligotts d9e79d6
Sort renderer client imports
eligotts ae516c1
Cover kept_tokens in the _NODE_DUMP_EXCLUDE docstring
eligotts 6e09559
Inline raw multimodal images: drop the ingress offload layer
eligotts File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Medium
verifiers/verifiers/v1/graph.py
Line 633 in 6e09559
The assistant node created in
_commit_turnomitsfinish_reasonandusage, so every committed response recordsfinish_reason=Noneandusage=Noneeven thoughResponsecarries those values. Truncation detection and provider usage/cost dashboards cannot work because the data is silently dropped. TheMessageNode.model_construct(...)call for the assistant node needs to passfinish_reason=response.finish_reasonandusage=response.usage.🚀 Reply "fix it for me" or copy this AI Prompt for your agent: