fix(client): update vLLM 0.26 token-serving import - #115
Merged
Conversation
S1ro1
force-pushed
the
fix/vllm-0.26-token-serving-import
branch
from
July 30, 2026 19:40
2477ad1 to
cc61c2e
Compare
S1ro1
force-pushed
the
fix/vllm-0.26-token-serving-import
branch
from
July 30, 2026 19:43
cc61c2e to
b6521ff
Compare
S1ro1
force-pushed
the
fix/vllm-0.26-token-serving-import
branch
from
July 30, 2026 19:44
b6521ff to
b37d40e
Compare
hallerite
marked this pull request as ready for review
July 30, 2026 19:44
hallerite
approved these changes
Jul 30, 2026
ApprovabilityVerdict: Approved b37d40e Mechanical dependency update to fix vLLM 0.26 import path compatibility. Changes are limited to updating an import path, removing version-specific comments, and consolidating multi-line strings. No logic or behavioral changes. You can customize Macroscope's approvability policy. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vLLM 0.26 moved the token-in/token-out serialization helpers from the serve.disagg package to scale_out.token_in_token_out. Update the lazy multimodal encoder import and its documentation so Qwen-VL feature serialization continues to work with the new release.
Validation:
Note
Low Risk
Import-path and comment-only compatibility fix for vLLM 0.26; multimodal encoding logic is unchanged.
Overview
Aligns Qwen-VL multimodal feature encoding with vLLM 0.26, which moved
encode_mm_kwargs_itemfromvllm.entrypoints.serve.disagg.mm_serdetovllm.entrypoints.scale_out.token_in_token_out.mm_serde. The lazy import in_build_qwen_vl_featuresand the engine-pluggability note in_build_mm_featuresare updated accordingly.Docs and comments no longer pin the client to “vLLM 0.20”; they describe the path generically as vLLM’s
/inference/v1/generateintegration.A few
MalformedGenerateResponseErrorandOverlongPromptErrormessages are tightened to single-line f-strings with no behavior change.Reviewed by Cursor Bugbot for commit b37d40e. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix vLLM token-serving import path for
encode_mm_kwargs_itemin_build_qwen_vl_featuresUpdates the import path for
encode_mm_kwargs_itemin client.py fromvllm.entrypoints.serve.disagg.mm_serdetovllm.entrypoints.scale_out.token_in_token_out.mm_serdeto match the module layout in vLLM 0.26. Also removes a version-specific reference in the module docstring and consolidates error message f-strings.Macroscope summarized b37d40e.