Skip to content

Start Command Feature - #809

Open
DamianB-BitFlipper wants to merge 2 commits into
mainfrom
start-command
Open

Start Command Feature#809
DamianB-BitFlipper wants to merge 2 commits into
mainfrom
start-command

Conversation

@DamianB-BitFlipper

@DamianB-BitFlipper DamianB-BitFlipper commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Note

Medium Risk
Changes sandbox creation contracts for VMs (no string start commands, different defaults) and CLI flags, which can break scripts that relied on implicit container defaults or shell-style VM commands.

Overview
Introduces a structured StartCommand (executable + args, no shell) for sandbox startup, aimed at VM workloads where argv must be preserved exactly.

SDK (prime-sandboxes): StartCommand is exported; Sandbox and CreateSandboxRequest accept start_command as either that object or a legacy string. VM creates reject string start_command, default to None when omitted (so they no longer inherit tail -f /dev/null), and serialize structured commands as {executable, args}.

CLI (prime sandbox create): Trailing arguments after -- map to StartCommand; --start-command remains container-only. Container defaults and explicit empty legacy strings are unchanged.

CI: Ruff lint step passes check --no-preview.

Docs and tests cover VM argv preservation, validation, and display formatting.

Reviewed by Cursor Bugbot for commit b35c0cd. Bugbot is set up for automated code reviews on this repo. Configure here.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 933c0e582a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Sandbox,
SandboxClient,
SandboxNotRunningError,
StartCommand,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Raise the prime-sandboxes dependency floor

When prime is installed or upgraded while the already-published prime-sandboxes==0.2.33 remains installed, this unconditional import raises ImportError because StartCommand is introduced by this commit, while packages/prime/pyproject.toml still permits version 0.2.33. Since prime_cli.main imports the sandbox module at startup, every CLI command is then unusable, not just the new sandbox feature; require the first SDK release that exports StartCommand.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant