Start Command Feature - #809
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 933c0e582a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| Sandbox, | ||
| SandboxClient, | ||
| SandboxNotRunningError, | ||
| StartCommand, |
There was a problem hiding this comment.
Raise the prime-sandboxes dependency floor
When prime is installed or upgraded while the already-published prime-sandboxes==0.2.33 remains installed, this unconditional import raises ImportError because StartCommand is introduced by this commit, while packages/prime/pyproject.toml still permits version 0.2.33. Since prime_cli.main imports the sandbox module at startup, every CLI command is then unusable, not just the new sandbox feature; require the first SDK release that exports StartCommand.
Useful? React with 👍 / 👎.
Note
Medium Risk
Changes sandbox creation contracts for VMs (no string start commands, different defaults) and CLI flags, which can break scripts that relied on implicit container defaults or shell-style VM commands.
Overview
Introduces a structured
StartCommand(executable+args, no shell) for sandbox startup, aimed at VM workloads where argv must be preserved exactly.SDK (
prime-sandboxes):StartCommandis exported;SandboxandCreateSandboxRequestacceptstart_commandas either that object or a legacy string. VM creates reject stringstart_command, default toNonewhen omitted (so they no longer inherittail -f /dev/null), and serialize structured commands as{executable, args}.CLI (
prime sandbox create): Trailing arguments after--map toStartCommand;--start-commandremains container-only. Container defaults and explicit empty legacy strings are unchanged.CI: Ruff lint step passes
check --no-preview.Docs and tests cover VM argv preservation, validation, and display formatting.
Reviewed by Cursor Bugbot for commit b35c0cd. Bugbot is set up for automated code reviews on this repo. Configure here.