Ignore .grok/skills in Lab workspaces - #791
Open
martian56 wants to merge 1 commit into
Open
Conversation
martian56
requested review from
DamianB-BitFlipper,
JannikSt,
JohannesHa,
burnpiro,
d42me,
kcoopermiller and
willccbb
as code owners
July 15, 2026 07:30
Author
|
@JannikSt can you take a look at this |
prime lab setup creates a .grok/skills directory when Grok is selected as a coding agent, but the Lab gitignore patterns and git-hygiene checks never listed it. The generated skill files ended up untracked and were never flagged, so they could be committed by accident. Both lists were hand-maintained copies of the per-agent skill directories, which is how grok slipped through. Derive them from a single LAB_AGENT_SKILL_DIRS tuple instead, add grok to it, and add a test that walks every agent in the registry and asserts its skill directory is covered by both lists so a new agent can't drift again.
martian56
force-pushed
the
fix-grok-skills-gitignore
branch
from
July 28, 2026 21:24
985b07c to
a1786b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #790.
When
grokis selected duringprime lab setup, the workspace gets a.grok/skills/directory, but that path was never added to.gitignoreand wasn't flagged byprime lab hygiene/prime lab doctor. Every other agent's skills directory is ignored, so grok's generated files could be committed by accident.The two lists in
lab_hygiene.py(LAB_GITIGNORE_PATTERNSandLAB_TRACKED_PREFIXES) were hand-maintained copies of the per-agent skills directories, and grok was missing from both. Rather than just add the one line, I pulled the skill directories into a singleLAB_AGENT_SKILL_DIRStuple and derive both lists from it, so they can't drift apart again.Added
tests/test_lab_hygiene.py, which walks every agent from the registry and asserts its project skill directory is covered by both lists. Without the fix it fails on grok; with it, it passes.Testing
The rest of the Lab test suite is unchanged by this PR. A handful of pre-existing failures in
tests/test_lab_setup.pyreproduce onmainas well — they're unrelated (Windows path-separator assertions and symlink behaviour in the download/skill-sync tests).