fix(pods): preserve equals signs in --env values - #788
Open
crazywriter1 wants to merge 1 commit into
Open
Conversation
Match sandbox parsing with split("=", 1) so URL/query values are not truncated.
crazywriter1
requested review from
DamianB-BitFlipper,
JannikSt,
JohannesHa,
burnpiro,
d42me,
kcoopermiller and
willccbb
as code owners
July 14, 2026 10:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prime pods create --env KEY=VALUEwithsplit("=", 1), matching sandbox CLI behavior==(e.g. connection strings)Test plan
uv run pytest packages/prime/tests/test_pods_create.py -qNote
Low Risk
Small CLI input-validation change with tests; no auth or API contract changes beyond correct env var payloads.
Overview
Fixes
prime pods create --envparsing so variable values keep any=characters (e.g. Postgres URLs with query params,FLAGS=a=b=c), aligning with the sandbox CLI.Parsing now splits only on the first
=, rejects entries without=, and exits early with a KEY=VALUE error before availability is loaded. Regression tests cover multi-=values and invalid--envinput.Reviewed by Cursor Bugbot for commit 8f8bec8. Bugbot is set up for automated code reviews on this repo. Configure here.