fix(nixl): replay strided views on inference#3113
Merged
Merged
Conversation
Collaborator
Author
artisanally crafted with love |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
A strided tensor can share the trainer root storage without being a contiguous transfer region. Treating that view as directly transportable fragments the NIXL copy plan and can make synchronization pathologically slow.
Validation
Validated with the Laguna-XS.2 NIXL + ModelExpress Kubernetes run:
Note
Medium Risk
Changes how trainer→inference weight slices are split between RDMA and local replay; incorrect boundaries could corrupt weights, but the fix is narrowly scoped to prefix eligibility in replay planning.
Overview
NIXL weight transfer now treats only contiguous same-dtype views of the trainer root as directly RDMA-able; the prefix walk in
plan_tensor_replaybreaks whenis_contiguous()fails, not only on dtype change or non-view tensors.Strided views that still alias root storage are no longer included in the bulk copy plan—those ops move into
replay_opsand run on the inference receive arena, avoiding fragmented NIXL copy plans and slow sync (as seen with staggered TP pool joins).Reviewed by Cursor Bugbot for commit c95589c. Bugbot is set up for automated code reviews on this repo. Configure here.