fix(orchestrator): drain after final train batch#3107
Draft
jooooonas wants to merge 2 commits into
Draft
Conversation
added 2 commits
July 22, 2026 12:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enter drain mode immediately after successfully sending the final configured training batch, rather than waiting for an unused overflow batch to complete.
Problem
The orchestrator currently starts draining only when:
step > max_stepsAfter sending the valid batch at
step == max_steps, it advances the step but continues scheduling rollouts. Another completeTrainBatchmust reachfinalize_train_batch()before the existing overflow guard stops training.That batch is discarded and cannot serve as a fallback. This wastes rollout work and makes shutdown depend on an unnecessary batch
completing. A slow or unhealthy rollout tail can therefore delay shutdown.
Change
After
sender.send()successfully sends the final valid batch, the orchestrator now:The existing
step > max_stepscheck remains as a defensive guard.Draining starts only after a valid batch is sent. Empty or fully filtered final-batch candidates continue to be retried.
Tests
Added one CPU-only regression test verifying that a valid final batch:
Ruff lint and formatting checks also pass.