decouple trainer step completion from weight broadcast#3024
Draft
tim0120 wants to merge 1 commit into
Draft
Conversation
tim0120
force-pushed
the
agent/trainer-step-ack
branch
from
July 14, 2026 00:54
b0e1830 to
d61a5b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ready_to_updaterelease out of broadcaster implementations and into trainer-step completionThis keeps
WeightWatcherweight-specific and avoids full-model or adapter serialization for static SFT. Policy-backed RL runs continue to use their existing weight broadcast paths.Multi-run behavior
A trainer step may update static and policy-backed runs together. Only policy-backed runs are included in weight publication; all updated runs receive their own
trainer_steps/step_N/STABLEcompletion marker and are released for their next batch.Validation
The repository lock currently supports Linux only, so the focused test was run on macOS with an ephemeral
uv --no-projectdependency environment.