feat(orchestrator): expose target_lag config#3008
Open
Abhishek21g wants to merge 2 commits into
Open
Conversation
Promote the hardcoded dispatch-gate lag to orchestrator.target_lag (default 1) with docs clarifying it is unrelated to max_off_policy_steps.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e482ab3. Configure here.
Gate reads orchestrator.target_lag from config; module constant was dead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
TARGET_LAGwas a hardcoded module constant gating how many batches the orchestrator may ship ahead ofpolicy.version. Operators confused it withmax_off_policy_steps(#2812).orchestrator.target_lag(Field(1, ge=1)) with docs distinguishing the two knobsdocs/training.mduseful-knobs tableDefault
1preserves current behavior exactly.Related: #2812 (note PR #2845 also open — happy to consolidate)
Verify
Note
Low Risk
Behavior is unchanged at the default; the change is config wiring and documentation with minimal orchestrator logic touched.
Overview
Replaces the hardcoded dispatch-gate constant with
orchestrator.target_lag(default 1), so operators can tune how many batches the orchestrator may ship ahead ofpolicy.versionwithout changing code.update_dispatch_gatenow compares lead againstself.config.target_laginstead of a module-levelTARGET_LAG.Docs clarify that
target_lag(dispatch pause / watchtime/wait_for_policy) is separate frommax_off_policy_steps(per-rollout staleness discard). Config field docstrings mirror that split. Unit tests cover default1and rejection of0.Reviewed by Cursor Bugbot for commit 1cdd081. Bugbot is set up for automated code reviews on this repo. Configure here.