Fix bicep extension to require transport to be specified otherwise return error - #1721
Merged
Steve Lee (SteveL-MSFT) merged 4 commits intoSep 15, 2026
Merged
Conversation
Copilot started reviewing on behalf of
Steve Lee (SteveL-MSFT)
September 14, 2026 21:06
View session
Steve Lee (SteveL-MSFT)
requested a review
from Andy Jordan (andyleejordan)
September 14, 2026 21:06
Andy Jordan (andyleejordan)
approved these changes
Sep 14, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Convert the localized error message to a String to resolve the compilation failure.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates the Bicep extension to error when transport is unspecified instead of defaulting to port 50051.
Changes:
- Adds localized missing-transport error handling.
- Bumps the extension version to 0.1.1.
- Synchronizes the lockfile version.
- The error path currently fails compilation because the localized message must be converted to an owned
String.
File summaries
| File | Summary |
|---|---|
dsc-bicep-ext/src/main.rs |
Rejects missing transport configuration. |
dsc-bicep-ext/locales/en-us.toml |
Adds the localized error message. |
dsc-bicep-ext/Cargo.toml |
Bumps the package version. |
Cargo.lock |
Synchronizes the package version. |
Review details
- Files reviewed: 3/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
added 2 commits
September 14, 2026 14:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Change code so that if the transport is not specified, return an error instead of defaulting to a well known port. Validated that bicep always sets the transport. Update version of binary.