Skip to content

test: add IEEE 14-bus power-flow validation case - #1577

Merged
Jerry-Jinfeng-Guo merged 13 commits into
PowerGridModel:mainfrom
VITA2aishu:issue-984-ieee14-validation
Sep 14, 2026
Merged

Jerry-Jinfeng-Guo merged 13 commits into
PowerGridModel:mainfrom
VITA2aishu:issue-984-ieee14-validation

Conversation

@VITA2aishu

Copy link
Copy Markdown
Contributor

Adds an IEEE 14-bus symmetrical power-flow validation case for #984.

The case is based on the publicly available IEEE 14-bus test system and includes:

PGM input data for the 14-bus network
Newton-Raphson validation configuration
expected bus voltage magnitudes and angles
source and conversion documentation

The conversion includes PQ loads, PV generators with voltage regulation, the slack source, branch charging, transformer tap ratios, and the bus 9 shunt.

The reference solution was also independently checked using an AC Newton-Raphson calculation. The PGM repository validation/CI result is still to be confirmed, so I am opening this as a draft.

Related issue: #984

@Jerry-Jinfeng-Guo

Copy link
Copy Markdown
Member

Hi @VITA2aishu , thank you for contributing this test case! Before we could proceed, could you add license file to each json as a standalone license file? You can take a look at the other test directories for reference. Once that is in place, we can approve the CI workflow.

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added feature New feature or request do-not-merge This should not be merged labels Sep 8, 2026
@VITA2aishu

Copy link
Copy Markdown
Contributor Author

Thanks! I’ve added the standalone license files for the three JSON files and pushed the changes. Please let me know if anything else is needed.

@figueroa1395

Copy link
Copy Markdown
Member

Hello @VITA2aishu, we are a bit busy at the moment, so we expect to review the PR towards the end of the week or the beginning of the next week.

That said, I already see that some commits aren't properly DCO signed (see here) and that your commits also don't have the verified batch, which means that they aren't cryptographically signed either. You can find more information on the former here and on the latter here. Once you have amended the commits, you will have to force push. Let us know if we can be of any assistance.

In addition, if you want to make sure that everything was done correctly + all test pass + some code quality and formatting standards are satisfied, I recommend you do uv run pre-commit run locally, that way the process here can go more smoothly.

Finally, once your PR is ready to be reviewed, please mark it as ready (instead of draft) so that gives us the thumbs up.

Thanks again for the contribution.

Signed-off-by: Aisvarya Sampath Kumar <aisvarya20@gmail.com>
Signed-off-by: Aisvarya Sampath Kumar <aisvarya20@gmail.com>
Signed-off-by: Aisvarya Sampath Kumar <aisvarya20@gmail.com>
Signed-off-by: Aisvarya Sampath Kumar <aisvarya20@gmail.com>
Signed-off-by: Aisvarya Sampath Kumar <aisvarya20@gmail.com>
Signed-off-by: Aisvarya Sampath Kumar <aisvarya20@gmail.com>
Signed-off-by: Aisvarya Sampath Kumar <aisvarya20@gmail.com>
Signed-off-by: Aisvarya Sampath Kumar <aisvarya20@gmail.com>
Signed-off-by: Aisvarya Sampath Kumar <aisvarya20@gmail.com>
Signed-off-by: Aisvarya Sampath Kumar <aisvarya20@gmail.com>
@VITA2aishu
VITA2aishu force-pushed the issue-984-ieee14-validation branch from cf0cbe5 to 4fe99de Compare September 9, 2026 11:49
@VITA2aishu
VITA2aishu marked this pull request as ready for review September 9, 2026 11:56
Signed-off-by: Aisvarya Sampath Kumar <aisvarya20@gmail.com>

@figueroa1395 figueroa1395 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @VITA2aishu,

I've reviewed and everything looks good (I just have a small comment). I also see that you have signed the previous commits as requested, thank you!

Hereby I've authorized CI to run. Let's see if anything needs to be adjusted then. I'll ping you once CI is through.

Note: I've also updated the base branch accordingly, so if changes are needed, make sure to adjust locally first.

Thanks for the contribution!

Comment thread tests/data/power_flow/ieee14/README.md Outdated
@figueroa1395 figueroa1395 removed the do-not-merge This should not be merged label Sep 10, 2026
@nitbharambe

Copy link
Copy Markdown
Member

The test cases look good!
Additionally versions of links:
caseformat/ieee14@a9e12bb
ITI/models@1d0d1e1

Signed-off-by: Aisvarya Sampath Kumar <aisvarya20@gmail.com>
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added the do-not-merge This should not be merged label Sep 14, 2026
@Jerry-Jinfeng-Guo

Copy link
Copy Markdown
Member

Hi @VITA2aishu , before we merge this new test case, can you let us know a bit more about how you calculated the results? I.e., can you disclose what is used in 'independently checked using an AC Newton-Raphson calculation'? Then we can proceed.

@nitbharambe

Copy link
Copy Markdown
Member

The data matches from the links provided in the README.md.

Hi @VITA2aishu , before we merge this new test case, can you let us know a bit more about how you calculated the results? I.e., can you disclose what is used in 'independently checked using an AC Newton-Raphson calculation'? Then we can proceed.

@nitbharambe nitbharambe removed the do-not-merge This should not be merged label Sep 14, 2026
@nitbharambe
nitbharambe added this pull request to the merge queue Sep 14, 2026
@nitbharambe
nitbharambe removed this pull request from the merge queue due to a manual request Sep 14, 2026
@Jerry-Jinfeng-Guo
Jerry-Jinfeng-Guo added this pull request to the merge queue Sep 14, 2026
Merged via the queue into PowerGridModel:main with commit 8e075ab Sep 14, 2026
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants