nix: add postgrest-with-oriole-17#4895
Conversation
|
Not sure whether you know that you can easily checkout my PR's branch and also push to it with GitHub's CLI tool by doing Thanks for the finding anyway, will use it on my PR. |
|
To be fair I did point at the exact change on #4845 (comment) but sure I will use a more git native workflow next time (will try github CLI, haven't used it yet). |
Sorry, this might have come across the wrong way. There was nothing wrong with this PR, it was very helpful. I just wanted to potentially save you some work next time, so you wouldn't have to create a new branch and PR. Essentially I just wanted to tell you that I have no problem with you pushing to my own PR if you wanted to (some people could be offended by pushing to their PRs, but I am not). |
|
Thanks for clarifying! I’ll now force push directly to the PR to test this tolerance 😃 I'm the same btw, I don't mind force pushing. At some point I remember github used to show a checkbox somewhere that said something like "Allow maintainers to make edits to this PR" but I don't see that anymore. |
|
@taimoorzaeem Thanks for confirming, I can see it too. I believe it was in another place before so I lost track of it. |

(not meant to merge)
PR to show the errors on the pg tests on #4845 are cleared.