Skip to content

nix: add postgrest-with-oriole-17#4895

Closed
steve-chavez wants to merge 1 commit into
PostgREST:mainfrom
steve-chavez:with-orioledb-bk
Closed

nix: add postgrest-with-oriole-17#4895
steve-chavez wants to merge 1 commit into
PostgREST:mainfrom
steve-chavez:with-orioledb-bk

Conversation

@steve-chavez
Copy link
Copy Markdown
Member

@steve-chavez steve-chavez commented May 7, 2026

(not meant to merge)

PR to show the errors on the pg tests on #4845 are cleared.

@wolfgangwalther
Copy link
Copy Markdown
Member

Not sure whether you know that you can easily checkout my PR's branch and also push to it with GitHub's CLI tool by doing gh pr checkout 4845. The remote branch is then correctly set up, so that you can push, too. I would have been entirely OK with you pushing that change (potentially as a fixup commit, so I could easier see the diff) to my PR directly.

Thanks for the finding anyway, will use it on my PR.

@steve-chavez
Copy link
Copy Markdown
Member Author

To be fair I did point at the exact change on #4845 (comment) but sure I will use a more git native workflow next time (will try github CLI, haven't used it yet).

@wolfgangwalther
Copy link
Copy Markdown
Member

To be fair I did point at the exact change on #4845 (comment) but sure I will use a more git native workflow next time (will try github CLI, haven't used it yet).

Sorry, this might have come across the wrong way. There was nothing wrong with this PR, it was very helpful. I just wanted to potentially save you some work next time, so you wouldn't have to create a new branch and PR. Essentially I just wanted to tell you that I have no problem with you pushing to my own PR if you wanted to (some people could be offended by pushing to their PRs, but I am not).

@steve-chavez
Copy link
Copy Markdown
Member Author

Thanks for clarifying! I’ll now force push directly to the PR to test this tolerance 😃

I'm the same btw, I don't mind force pushing. At some point I remember github used to show a checkbox somewhere that said something like "Allow maintainers to make edits to this PR" but I don't see that anymore.

@taimoorzaeem
Copy link
Copy Markdown
Member

At some point I remember github used to show a checkbox somewhere that said something like "Allow maintainers to make edits to this PR" but I don't see that anymore.

Strange, I still see it though:

image

@steve-chavez
Copy link
Copy Markdown
Member Author

@taimoorzaeem Thanks for confirming, I can see it too. I believe it was in another place before so I lost track of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants