Nebbaymechs as Exosuits, Legally Distinct from Mechas, obviously. by Mechoid · Pull Request #8956 · PolarisSS13/Polaris

Mechoid · 2023-02-15T03:25:58Z

Work on porting baymechs as exosuits, legally distinct from Mechs:tm:

Greenjoe12345 · 2023-02-17T16:30:27Z

+/obj/item/mech_component/sensors/attackby(var/obj/item/thing, var/mob/user)
+	if(istype(thing, /obj/item/mech_component/control_module))
+		if(software)
+			to_chat(user, SPAN_WARNING("\The [src] already has a control modules installed."))


A control module

Greenjoe12345 · 2023-02-17T16:32:40Z

+
+/obj/item/ammo_magazine/mech/smg_top
+	name = "large 7mm magazine"
+	desc = "A large magazine for a mech's gun. Looks way too big for a normal gun."


Might want the desc on the parent of this, so it'll show for the other mags?

Mechoid · 2023-02-18T10:44:30Z

Right, I don't quite understand why Dreamchecker is complaining now, as 2 are global procs, and one is just a for loop with an internal var

Greenjoe12345 · 2023-02-18T18:28:41Z

@@ -0,0 +1,90 @@
+/mob/living/exosuit/premade/light


This and the sleek exosuit seem to be almost the same thing, just with slight different descriptions/names, are they differernt icons?

Different icons, yes.

Atermonera · 2023-03-09T02:05:55Z

For the record, I am working on a review of this, but its size sorta demands it go to the backlog given the volume of PRs open rn.

Atermonera

That took, entirely longer than it ought to have, but I have completed An Serious Review of this.

Atermonera · 2023-02-26T21:25:16Z

+		if(A.RelayMouseDrag(src_object, over_object, src_location, over_location, src_control, over_control, params, src))
+			return
+
+	if(over_object)


Suggested change

if(over_object)

if(over_object && !incapacitated())

Atermonera · 2023-02-26T21:26:00Z

+	else if(!isturf(loc))
+		var/atom/movable/AM = loc


What if loc is null?

Atermonera · 2023-02-26T21:43:19Z

+	var/brute_damage = 0
+	var/burn_damage = 0
+	var/max_damage = 60
+	var/damage_state = 1


Magic number?

Atermonera · 2023-02-26T21:44:46Z

+	dir = SOUTH
+
+/obj/item/mech_component/proc/query_color(var/mob/living/user)
+	if(user)


Suggested change

if(user)

if(!istype(user))

return FALSE

Atermonera · 2023-02-26T21:45:36Z

+/obj/item/mech_component/examine(mob/user)
+	. = ..()
+	if(ready_to_install())
+		to_chat(user, SPAN_NOTICE("It is ready for installation."))


. += SPAN_NOTICE("It is ready for installation.")

Also need this format in every definition of show_missing_parts()

Atermonera · 2023-11-27T06:52:17Z

+	else
+		if(!newloc)
+			newloc = get_step(src, direct)
+		if(newloc && legs && legs.can_move_on(loc, newloc))
+			. = ..(newloc, direct)
+			next_step = world.time + legs.move_delay
+			if(. && !istype(loc, /turf/space))
+				playsound(src.loc, mech_step_sound, 40, 1)
+	return .


Suggested change

else

if(!newloc)

newloc = get_step(src, direct)

if(newloc && legs && legs.can_move_on(loc, newloc))

. = ..(newloc, direct)

next_step = world.time + legs.move_delay

if(. && !istype(loc, /turf/space))

playsound(src.loc, mech_step_sound, 40, 1)

return .

. = FALSE

if(!newloc)

newloc = get_step(src, direct)

if(newloc && legs && legs.can_move_on(loc, newloc))

. = ..(newloc, direct)

next_step = world.time + legs.move_delay

if(. && !istype(loc, /turf/space))

playsound(src.loc, mech_step_sound, 40, 1)

All the previous return statements are explicitly returning FALSE anyways.

Atermonera · 2023-11-27T06:52:31Z

+/*
+/datum/movement_handler/mob/space/exosuit
+	expected_host_type = /mob/living/exosuit
+
+// Space movement
+/datum/movement_handler/mob/space/exosuit/DoMove(var/direction, var/mob/mover)
+
+	if(!mob.check_solid_ground())
+		mob.anchored = FALSE
+		var/allowmove = mob.Allow_Spacemove(0)
+		if(!allowmove)
+			return MOVEMENT_HANDLED
+		else if(allowmove == -1 && mob.handle_spaceslipping()) //Check to see if we slipped
+			return MOVEMENT_HANDLED
+		else
+			mob.inertia_dir = 0 //If not then we can reset inertia and move
+	else mob.anchored = TRUE
+
+/datum/movement_handler/mob/space/exosuit/MayMove(var/mob/mover, var/is_external)
+	if((mover != host) && is_external)
+		return MOVEMENT_PROCEED
+
+	if(!mob.check_solid_ground())
+		if(!mob.Allow_Spacemove(0))
+			return MOVEMENT_STOP
+	return MOVEMENT_PROCEED
+
+/mob/living/exosuit/lost_in_space()
+	for(var/atom/movable/AM in contents)
+		if(!AM.lost_in_space())
+			return FALSE
+	return !pilots.len
+
+/mob/living/exosuit/fall_damage()
+	return 100 //Exosuits are big and heavy
+
+/mob/living/exosuit/handle_fall_effect(var/turf/landing)
+	// Return here if for any reason you shouldn´t take damage
+	..()
+	var/damage = 30 //Enough to cause a malfunction if unlucky
+	apply_damage(rand(0, damage), BRUTE, BP_R_LEG) //Any leg is good, will damage both
+*/


Atermonera · 2023-11-27T06:54:54Z

+		if(WT.welding)
+			cutting = TRUE


Consume weldingfuel?

Atermonera · 2023-11-27T07:02:36Z

@@ -0,0 +1,216 @@
+#define BAR_CAP 12


You should #undef this at the end of the file, or else it belongs in __defines

Moved to the defines

Atermonera · 2023-11-27T07:12:21Z

+/obj/item/mech_component/manipulators/combat
+	name = "combat arms"
+	exosuit_desc_string = "flexible, advanced manipulators"
+	icon_state = "combat_arms"
+	melee_damage = 5
+	action_delay = 10
+	power_use = 50


Should all the components defined in /premade go into files in /components that sort by component type, so it's easier to compare the different options?

…r Now:tm:

…n exosuitmob instead of a pilot. R&D designs added.

desc adjustment

Creates initialize-only proc for exos that doesn't care about the user.

Mechoid · 2024-04-24T21:42:56Z

Am I doing something wrong or do rebases just, do that.

Mechoid added Do Not Merge Generic DNM label. and removed Do Not Merge Generic DNM label. labels Feb 15, 2023

Mechoid marked this pull request as ready for review February 16, 2023 10:46

Mechoid changed the title ~~[WIP] [DNM] Nebbaymechs as Exosuits, Legally Distinct from Mechas, obviously.~~ Nebbaymechs as Exosuits, Legally Distinct from Mechas, obviously. Feb 16, 2023

Greenjoe12345 reviewed Feb 17, 2023

View reviewed changes

Greenjoe12345 reviewed Feb 18, 2023

View reviewed changes

Atermonera added Feature The PR adds new functionality in some way. Port [PR] This is code or assets from another codebase. labels Feb 26, 2023

Spookerton added the Stale [PR] This requires additional work and appears abandoned. label Aug 23, 2023

Spookerton marked this pull request as draft August 23, 2023 15:16

Mechoid force-pushed the NebbayMechsIMeanExosuits branch from 2975058 to 5ba9fb1 Compare September 4, 2023 12:15

Mechoid marked this pull request as ready for review September 4, 2023 12:15

Mechoid force-pushed the NebbayMechsIMeanExosuits branch 2 times, most recently from 34201cd to 6101752 Compare September 4, 2023 14:50

Atermonera suggested changes Nov 27, 2023

View reviewed changes

Atermonera removed the Stale [PR] This requires additional work and appears abandoned. label Nov 28, 2023

Mechoid added 12 commits April 24, 2024 14:12

Work on porting baymechs as exosuits, legally distinct from Mechs. Fo…

c54784f

…r Now:tm:

Continued. Neb icons acquired as variants. Fix quirk in handling as a…

91d61d5

…n exosuitmob instead of a pilot. R&D designs added.

fixfix

267049b

Linter to the rescue.

f94ea0c

get_cell()

09e0996

Exosuits can charge.

7656faf

A control modules

b5b45f6

desc adjustment

linter sacrifice

ecd0210

Move Intent Update

557b853

Initialize should return.

a56bbb6

crouching user hidden sleep

bbbd9da

Creates initialize-only proc for exos that doesn't care about the user.

Wreckage spawning no longer has a sleep.

91fd698

Mechoid added 4 commits April 24, 2024 14:33

The great PR review alignment.

4118aba

Magic number and null-loc.

b8538ed

Mousedrag and component damage state calculation.

d3a6e55

Dreamchecker

e6f15eb

Mechoid force-pushed the NebbayMechsIMeanExosuits branch from 0549bfe to e6f15eb Compare April 24, 2024 21:41

Uh oh!

Conversation

Mechoid commented Feb 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Mechoid commented Feb 18, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Atermonera commented Mar 9, 2023

Uh oh!

Atermonera left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Mechoid commented Apr 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Mechoid commented Feb 15, 2023 •

edited

Loading