Fix hardcoded rlds_data_dir in pi05_full_droid_finetune config - #1036
Open
yurekami wants to merge 1 commit into
Open
Fix hardcoded rlds_data_dir in pi05_full_droid_finetune config#1036yurekami wants to merge 1 commit into
yurekami wants to merge 1 commit into
Conversation
`pi05_full_droid_finetune` shipped with `rlds_data_dir="/mnt/pi-data/kevin"`, a path that only resolves on an internal machine, while the comment above it, the sibling `pi0_fast_full_droid_finetune` config, and the PolaRiS configs all use the placeholder `<path_to_droid_rlds_dataset>`. Use the same placeholder so the shipped default is the documented one, and add a config test that guards both full-DROID configs. Fixes Physical-Intelligence#1022 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011vZKTbRaDh8FuXSbVpQomD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pi05_full_droid_finetunesetsrlds_data_dir="/mnt/pi-data/kevin", a path that only exists on an internal machine, while the comment above it, the siblingpi0_fast_full_droid_finetuneconfig, and the PolaRiS configs all use the<path_to_droid_rlds_dataset>placeholder. This switches the default to the same placeholder.Repro on
main:python -c "import openpi.training.config as c; print(c.get_config('pi05_full_droid_finetune').data.rlds_data_dir)"prints/mnt/pi-data/kevin.Fixes #1022
🤖 Generated with Claude Code
https://claude.ai/code/session_011vZKTbRaDh8FuXSbVpQomD