Skip to content

Update to Node 26 - #2627

Merged
slifty merged 1 commit into
mainfrom
2585-update-to-node-26
Oct 27, 2026
Merged

slifty merged 1 commit into
mainfrom
2585-update-to-node-26

Conversation

@slifty

@slifty slifty commented Oct 15, 2026

Copy link
Copy Markdown
Member

Per our policy we want to be using the active version of Node.

Closes #2585

🤖 Generated with Claude Code (session 45933dbf-6fef-402e-8669-d5fa19e0bf9e)

Copilot AI lite review requested due to automatic review settings October 15, 2026 15:25

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The version references are consistent across the runtime, tooling, and lockfile, with no unresolved findings.

0 open findings

What changed in this PR

Updates the service’s Node.js version from 24 to 26, in line with the project’s active-version policy.

Changes:

  • Updates the local and Docker runtime versions.
  • Aligns TypeScript configuration, Node types, and locked dependencies with Node 26.
File Description
tsconfig.json Uses the Node 26 TypeScript preset.
tsconfig.dev.json Uses the Node 26 development preset.
package.json Requires Node 26 and updates development dependencies.
package-lock.json Locks the updated dependency versions.
Dockerfile Uses the Node 26 base image.
.node-version Selects Node 26 locally.

🧠 Review effort: Lite


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@slifty
slifty requested review from bickelj and a lite review from Copilot October 15, 2026 15:28
@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

🔎 A preview deployment of this pull request is available at https://utilities.philanthropydatacommons.org/pdc-service-preview-2627-wm4pl/ (and upstream https://pdc-service-preview-2627-wm4pl.ondigitalocean.app) assuming this PR is still open. 🔍

@codecov

codecov Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.03%. Comparing base (1d8fa7e) to head (ea6939d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2627   +/-   ##
=======================================
  Coverage   94.03%   94.03%           
=======================================
  Files         348      348           
  Lines        4492     4492           
  Branches      611      609    -2     
=======================================
  Hits         4224     4224           
  Misses        267      267           
  Partials        1        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The version references and related dependency updates are consistent, with no unresolved findings.

0 open findings

🧠 Review effort: Lite

@slifty

slifty commented Oct 15, 2026

Copy link
Copy Markdown
Member Author

Moving this to draft since v26 doesn't become Active until October 28th (not merely "October").

Will re-open then.

@slifty
slifty marked this pull request as draft October 15, 2026 15:40

@bickelj bickelj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Watch for GLM-5.2's feedback as well, take it or leave it.

@bickelj-agent bickelj-agent left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally with nvm (Node v26.12.0): npm ci, npm run build, lint:tsc, lint:eslint, and test:unit all pass (unit suite-load failures are missing env vars and reproduce identically on Node 24). The six changed files are the only Node-version references in the repo; all 11 setup-node steps read node-version-file: .node-version, and node:26-trixie-slim is published, so nothing was missed.

One non-blocking note in-band on tsconfig.json.

— GLM-5.2

Comment thread tsconfig.json Resolved
@slifty
slifty marked this pull request as ready for review October 27, 2026 15:18
Per our policy we want to be using the active version of Node.

Issue #2585 Update to Node 26

Claude-Session: 45933dbf-6fef-402e-8669-d5fa19e0bf9e
@slifty
slifty force-pushed the 2585-update-to-node-26 branch from f4b5ad5 to ea6939d Compare October 27, 2026 15:21
@slifty
slifty enabled auto-merge October 27, 2026 15:22
@slifty
slifty merged commit 5b34b6a into main Oct 27, 2026
23 checks passed
@slifty
slifty deleted the 2585-update-to-node-26 branch October 27, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to Node 26

4 participants