Repository navigation
Update to Node 26 - #2627
Update to Node 26#2627
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The version references are consistent across the runtime, tooling, and lockfile, with no unresolved findings.
0 open findings
What changed in this PR
Updates the service’s Node.js version from 24 to 26, in line with the project’s active-version policy.
Changes:
- Updates the local and Docker runtime versions.
- Aligns TypeScript configuration, Node types, and locked dependencies with Node 26.
| File | Description |
|---|---|
tsconfig.json |
Uses the Node 26 TypeScript preset. |
tsconfig.dev.json |
Uses the Node 26 development preset. |
package.json |
Requires Node 26 and updates development dependencies. |
package-lock.json |
Locks the updated dependency versions. |
Dockerfile |
Uses the Node 26 base image. |
.node-version |
Selects Node 26 locally. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
🔎 A preview deployment of this pull request is available at https://utilities.philanthropydatacommons.org/pdc-service-preview-2627-wm4pl/ (and upstream https://pdc-service-preview-2627-wm4pl.ondigitalocean.app) assuming this PR is still open. 🔍 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2627 +/- ##
=======================================
Coverage 94.03% 94.03%
=======================================
Files 348 348
Lines 4492 4492
Branches 611 609 -2
=======================================
Hits 4224 4224
Misses 267 267
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Moving this to draft since v26 doesn't become Active until October 28th (not merely "October"). Will re-open then. |
bickelj
left a comment
There was a problem hiding this comment.
LGTM.
Watch for GLM-5.2's feedback as well, take it or leave it.
bickelj-agent
left a comment
There was a problem hiding this comment.
Verified locally with nvm (Node v26.12.0): npm ci, npm run build, lint:tsc, lint:eslint, and test:unit all pass (unit suite-load failures are missing env vars and reproduce identically on Node 24). The six changed files are the only Node-version references in the repo; all 11 setup-node steps read node-version-file: .node-version, and node:26-trixie-slim is published, so nothing was missed.
One non-blocking note in-band on tsconfig.json.
— GLM-5.2
Per our policy we want to be using the active version of Node. Issue #2585 Update to Node 26 Claude-Session: 45933dbf-6fef-402e-8669-d5fa19e0bf9e
f4b5ad5 to
ea6939d
Compare
Per our policy we want to be using the active version of Node.
Closes #2585
🤖 Generated with Claude Code (session 45933dbf-6fef-402e-8669-d5fa19e0bf9e)