Repository navigation
Support dynamic control values in captured qp.ctrl - #3373
Conversation
[sc-133997] Assisted-by: Codex
[sc-133997] Assisted-by: Codex
|
Need PennyLaneAI/pennylane#10356 to get in first |
|
Remember to bump PL version tomorrow! @JerryChen97 I'll approve then after CI is green |
Assisted-by: Codex
Assisted-by: Codex
|
Not sure how much we care about non-boolean, but let me prepare one more fix to simply |
You mean one more fix in PL? |
Yes. But actually I do suggest remove such tests from Catalyst. If it's in Pennylane things will be much easier.... |
Let's just do what the current system does for now I guess |
This is the fix needed: https://github.com/PennyLaneAI/pennylane/pull/10367/changes#diff-4d674c6197f96fff76100645d95e27af0e6bddf23dad921ddf5d5150f70b746dL303 |
Co-authored-by: Yushao Chen (Jerry) <chenys13@outlook.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3373 +/- ##
=======================================
Coverage 96.14% 96.15%
=======================================
Files 177 177
Lines 21582 21587 +5
Branches 2153 2153
=======================================
+ Hits 20751 20756 +5
Misses 643 643
Partials 188 188 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…h how we test usually
Fixes captured
qp.ctrlcallables with mixed static and runtime Boolean control values. The interpreter reads control values after the control wires, and lowering passes them to the existing SSActrlvals.Requires PennyLaneAI/pennylane#10356. The new operand layout also applies to static controls, so the two changes need coordinated merging and compatible dependency versions. This overlaps #3366's
work_wire_typechanges.Validation:
default.qubit.Local execution used native artifacts from
aa5eb08a7. The branch is now based on631b95e4a; the Python patch is unchanged, but the newer native passes were not rebuilt locally.[sc-133997]
Assisted by Codex. WIP; human review is in progress.