Fix runtime_artifacts walk performance - #3219
Open
mehrdad2m wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
!benchmark |
Contributor
|
What I don't understand is how a single walk could produce a meaningful degradation, since we do do walks quite often (although I agree recursive walks should be avoided if unnecessary) 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
Currently there is a performance degradation issue with
catalyst.runtime_artifactswhere it walks the entire IR operations looking for runtime_artifacts which is unnecessary.Description of the Change:
It now visits module operations only, instead of every operation in the program.
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-129402]