Skip to content

use parallel mode for coverage - #3215

Merged
paul0403 merged 2 commits into
mainfrom
fix-concurrent-codecov-issue
Sep 14, 2026
Merged

use parallel mode for coverage#3215
paul0403 merged 2 commits into
mainfrom
fix-concurrent-codecov-issue

Conversation

@mehrdad2m

Copy link
Copy Markdown
Contributor

Context:
make lit-coverage runs lit with -j$(nproc) while every worker does coverage run --append into one shared .coverage.lit. That file is a SQLite database and does not tolerate concurrent writers, so workers intermittently abort.

Description of the Change:

  • frontend/test/lit/lit.cfg.py: --append → --parallel-mode, so each worker writes its own .coverage.lit.<host>.<pid>.<random>

  • Makefile: merge them at the end of lit-coverage with coverage combine --data-file=$(MK_DIR)/.coverage.lit

Benefits:

Possible Drawbacks:

Related GitHub Issues:

Assisted by: Claude Opus 5

@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.62%. Comparing base (e0bf6d6) to head (1261917).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3215      +/-   ##
==========================================
- Coverage   97.23%   95.62%   -1.61%     
==========================================
  Files          40      177     +137     
  Lines        4522    20877   +16355     
  Branches        0     2102    +2102     
==========================================
+ Hits         4397    19964   +15567     
- Misses        125      725     +600     
- Partials        0      188     +188     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mehrdad2m
mehrdad2m requested review from a team and joeycarter September 10, 2026 20:00

@paul0403 paul0403 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@joeycarter joeycarter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Opus 5 we trust.

(But yes, this solutions agrees with the description in the CodeCov docs).

@paul0403
paul0403 merged commit 1f891c7 into main Sep 14, 2026
38 checks passed
@paul0403
paul0403 deleted the fix-concurrent-codecov-issue branch September 14, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants