Conversation
lazypanda10117
approved these changes
Sep 10, 2026
dime10
requested review from
a team and
comp-phys-marc
and removed request for
comp-phys-marc
September 11, 2026 19:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Quantum dialect now depends on several other dialects (meaning it uses symbols from those compilation units). This can cause downstream build errors, e.g. in a plugin which only links against the Quantum dialect and doesn't know that links to other dependent dialects are needed as well. In a base Catalyst build this is not an issue since all executable targets we have include all dialects anyway.
The fix makes it so those dependencies are explicitly declared by the component that depends on it, which we should follow as a general practice.
We might also want to interrogate whether these dependencies are truly necessary for the Quantum dialect, or whether it could be made more independent.