Add numeric attribute types to the Pyval generator for on-demand rule tracing - #3200
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3200 +/- ##
==========================================
- Coverage 97.23% 95.32% -1.92%
==========================================
Files 40 177 +137
Lines 4522 20877 +16355
Branches 0 2102 +2102
==========================================
+ Hits 4397 19900 +15503
- Misses 125 771 +646
- Partials 0 206 +206 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dime10
added this pull request to stack #3207
September 9, 2026 21:31
dime10
force-pushed
the
add-missing-attribute-types-odg
branch
from
September 9, 2026 21:37
93e8e9c to
904e120
Compare
dime10
force-pushed
the
add-missing-attribute-types-odg
branch
from
September 11, 2026 15:14
904e120 to
9a9cbc5
Compare
dime10
force-pushed
the
add-missing-attribute-types-odg
branch
from
September 11, 2026 15:39
9a9cbc5 to
287f2f3
Compare
kipawaa
approved these changes
Sep 14, 2026
paul0403
approved these changes
Sep 14, 2026
+ raise on unknown type rather than emitting a placeholder string, which is confusing to debug.
paul0403
force-pushed
the
add-missing-attribute-types-odg
branch
from
September 14, 2026 16:24
287f2f3 to
ac35c6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly standalone PR to fix the "placeholder" string being generated for unknown attribute types. The known attributes are extended to include bools, ints, and floats, and an error is now raised instead of the bogus value.