Skip to content

[DO NOT MERGE] Migrate xdist to use logical cores instead of only physical #3199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mlxd wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[DO NOT MERGE] Migrate xdist to use logical cores instead of only physical #3199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d88dfb5
Migrate xdist to use logical cores instead of only physical
mlxd Sep 8, 2026
3c9dca8
Merge branch 'main' into mlxd/auto_to_logical
mlxd Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/build-wheel-linux-arm64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,14 +500,14 @@ jobs:

- name: Run Python Pytest Tests
run: |
python${{ matrix.python_version }} -m pytest frontend/test/pytest -n auto
python${{ matrix.python_version }} -m pytest frontend/test/pytest --backend="lightning.kokkos" -n auto -m "not xdsl"
python${{ matrix.python_version }} -m pytest frontend/test/pytest -n logical
python${{ matrix.python_version }} -m pytest frontend/test/pytest --backend="lightning.kokkos" -n logical -m "not xdsl"
python${{ matrix.python_version }} -m pytest frontend/test/async_tests
python${{ matrix.python_version }} -m pytest frontend/test/pytest --runbraket=LOCAL -n auto -m "not xdsl" || true
python${{ matrix.python_version }} -m pytest frontend/test/test_oqc/oqc -n auto
python${{ matrix.python_version }} -m pytest frontend/test/pytest --runbraket=LOCAL -n logical -m "not xdsl" || true
python${{ matrix.python_version }} -m pytest frontend/test/test_oqc/oqc -n logical

- name: Run Standalone Plugin Tests
# Run only on Thursday at the given time
if: env.BUILD_STANDALONE_PLUGIN == 'true'
run: |
python${{ matrix.python_version }} -m pytest standalone_plugin_wheel/standalone_plugin/test -n auto
python${{ matrix.python_version }} -m pytest standalone_plugin_wheel/standalone_plugin/test -n logical
10 changes: 5 additions & 5 deletions .github/workflows/build-wheel-linux-x86_64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,14 +542,14 @@ jobs:

- name: Run Python Pytest Tests
run: |
python${{ matrix.python_version }} -m pytest frontend/test/pytest -n auto
python${{ matrix.python_version }} -m pytest frontend/test/pytest --backend="lightning.kokkos" -n auto -m "not xdsl"
python${{ matrix.python_version }} -m pytest frontend/test/pytest -n logical
python${{ matrix.python_version }} -m pytest frontend/test/pytest --backend="lightning.kokkos" -n logical -m "not xdsl"
python${{ matrix.python_version }} -m pytest frontend/test/async_tests
python${{ matrix.python_version }} -m pytest frontend/test/pytest --runbraket=LOCAL -n auto -m "not xdsl" || true
python${{ matrix.python_version }} -m pytest frontend/test/test_oqc/oqc -n auto
python${{ matrix.python_version }} -m pytest frontend/test/pytest --runbraket=LOCAL -n logical -m "not xdsl" || true
python${{ matrix.python_version }} -m pytest frontend/test/test_oqc/oqc -n logical

- name: Run Standalone Plugin Tests
# Run only on Thursday at the given time
if: env.BUILD_STANDALONE_PLUGIN == 'true'
run: |
python${{ matrix.python_version }} -m pytest standalone_plugin_wheel/standalone_plugin/test -n auto
python${{ matrix.python_version }} -m pytest standalone_plugin_wheel/standalone_plugin/test -n logical
10 changes: 5 additions & 5 deletions .github/workflows/build-wheel-macos-arm64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,14 +521,14 @@ jobs:

- name: Run Python Pytest Tests
run: |
python${{ matrix.python_version }} -m pytest frontend/test/pytest -n auto
python${{ matrix.python_version }} -m pytest frontend/test/pytest --backend="lightning.kokkos" -n auto -m "not xdsl"
python${{ matrix.python_version }} -m pytest frontend/test/pytest -n logical
python${{ matrix.python_version }} -m pytest frontend/test/pytest --backend="lightning.kokkos" -n logical -m "not xdsl"
python${{ matrix.python_version }} -m pytest frontend/test/async_tests
python${{ matrix.python_version }} -m pytest frontend/test/pytest --runbraket=LOCAL -n auto -m "not xdsl" || true
python${{ matrix.python_version }} -m pytest frontend/test/test_oqc/oqc -n auto
python${{ matrix.python_version }} -m pytest frontend/test/pytest --runbraket=LOCAL -n logical -m "not xdsl" || true
python${{ matrix.python_version }} -m pytest frontend/test/test_oqc/oqc -n logical

- name: Run Standalone Plugin Tests
# Run only on Thursday at the given time
if: env.BUILD_STANDALONE_PLUGIN == 'true'
run: |
python${{ matrix.python_version }} -m pytest standalone_plugin_wheel/standalone_plugin/test -n auto
python${{ matrix.python_version }} -m pytest standalone_plugin_wheel/standalone_plugin/test -n logical
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ SCIPY_DIR := $(shell python -c 'import os, scipy_openblas32; print(os.path.dirna
ASAN_FLAGS += DYLD_LIBRARY_PATH="$(RT_BUILD_DIR)/lib:$(SCIPY_DIR)/lib:$(DYLD_LIBRARY_PATH)"
endif

PARALLELIZE := -n auto
PARALLELIZE := -n logical
ifeq ($(ENABLE_ASAN),ON)
ifeq ($(PLATFORM),Darwin)
# Launching subprocesses with ASAN on macOS is not supported (see https://stackoverflow.com/a/47853433).
Expand Down
Loading