Skip to content

[GOID] Use unified printing for parameter types - #3191

Merged
paul0403 merged 2 commits into
mainfrom
type-printing-is-ssot
Sep 14, 2026
Merged

paul0403 merged 2 commits into
mainfrom
type-printing-is-ssot

Conversation

@dime10

@dime10 dime10 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Small follow-up on #3188 to remove the manual Python -> MLIR type conversion and manual string serialization of MLIR types for the GraphOpID format. Instead the Python binding utilities are used and the MLIR attribute printer handles the string serialization.

As a side-effect, more types are supported now that weren't present in the table (e.g. uint).

@dime10
dime10 requested review from kipawaa and paul0403 September 4, 2026 21:25
@dime10 dime10 changed the title [GOID] Use unified printing for the static data portion [GOID] Use unified printing for parameter types Sep 4, 2026
@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.33%. Comparing base (1011e55) to head (6cb5b3b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3191      +/-   ##
==========================================
+ Coverage   95.32%   95.33%   +0.01%     
==========================================
  Files         177      177              
  Lines       20874    20877       +3     
  Branches     2103     2102       -1     
==========================================
+ Hits        19899    19904       +5     
+ Misses        768      766       -2     
  Partials      207      207              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dime10
dime10 added this pull request to stack #3207 September 9, 2026 21:31
@dime10
dime10 force-pushed the type-printing-is-ssot branch from 0ba3196 to a240b49 Compare September 9, 2026 21:35
@dime10
dime10 force-pushed the type-printing-is-ssot branch from a240b49 to ee2cfc5 Compare September 11, 2026 15:14
Base automatically changed from minimal-single-source to main September 11, 2026 15:39
@dime10
dime10 force-pushed the type-printing-is-ssot branch from ee2cfc5 to f42ca0d Compare September 11, 2026 15:39
Comment thread frontend/catalyst/from_plxpr/qref_operator2_primitives.py
@paul0403
paul0403 merged commit f3c06e2 into main Sep 14, 2026
49 of 50 checks passed
@paul0403
paul0403 deleted the type-printing-is-ssot branch September 14, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants