Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…dings - Validate that the quantum.operator PPR angle_denominator attribute is a signless integer with bit width >= 2 before calling IntegerAttr::getInt(). A handwritten si64 previously crashed the compiler (assertion failure), and a bare i1 true silently sign-extended to -1. Both now emit the existing integer-angle-denominator diagnostic. - Split the combined qubit-mode diagnostic into a register-mode message and a zero-qubit message, with small dedicated tests for each. - Tighten the positive to-ppr PPR-operator MLIR checks with CHECK-LABEL/ CHECK-NOT and by capturing SSA values so the second PPR is checked to consume the first PPR's output. - Document the to_ppr PPR direct-lowering improvement in the dev changelog, referencing upstream PennyLane PR #10107. - Remove the inert "PPR" entry from RUNTIME_OPERATIONS (no shipped device declares it and the runtime cannot execute raw PPR) and the now-tautological test_ppr_is_supported_by_qjit_capabilities test; the real frontend integration tests already prove PPR survives and lowers without PauliRot. - Remove committed internal workflow artifacts under docs/superpowers/ (this repo uses doc/ for shipped documentation). Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
dwierichs
commented
Sep 4, 2026
| return convertMultiRZGate(originOp, rewriter); | ||
| } else if (auto originOp = dyn_cast<PauliRotOp>(op)) { | ||
| return convertPauliRotGate(originOp, rewriter); | ||
| } else if (auto originOp = dyn_cast<OperatorOp>(op)) { |
Contributor
Author
There was a problem hiding this comment.
Would it be better to add a PPROp similar to PauliRotOp? 🤔
Co-authored-by: Cursor <cursoragent@cursor.com>
This reverts commit b0baf11.
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
dwierichs
commented
Sep 14, 2026
| @@ -0,0 +1,180 @@ | |||
| # Adjoint PPR-to-PPM Implementation Plan | |||
Contributor
Author
There was a problem hiding this comment.
Will have to work on the agent not committing its helper files. Sorry about that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
PennyLaneAI/pennylane#10107 adds a new
qp.PPRclass that represents discrete PPRs.We would like this op to get lowered into a
pbc.pprdirectly when usingto_ppr.Description of the Change:
Register
PPRinto_pprand lower it topbc.ppr.Benefits:
Cheaper decompositions/compilation.
Possible Drawbacks:
Related GitHub Issues: