ensure deps and Roxygen are up to date before running pkgdown#4036
Conversation
divine7022
left a comment
There was a problem hiding this comment.
LGTM! totally makes sense
droped one tiny inline, not a blocker
| # Generates a list of regular files at any depth inside its argument, | ||
| # excluding those in any `docs` folder | ||
| files_in_dir = $(filter-out \ | ||
| ${1}/docs/%, \ |
There was a problem hiding this comment.
any reason for not using this ?
reads same to me though, since next char is / so there's no $1docs concat risk,
just wanna make sure i am not missing something on second expan
| ${1}/docs/%, \ | |
| $1/docs/%, \ |
There was a problem hiding this comment.
As far as I know* $1 and ${1} will act identically here, I just chose the delimited one on principle -- my rule is that if I'm even starting to ask "is there concat risk here", I add braces rather than think about it.
*(but note I'm saying this without looking anything up; Make variable syntax does differ from shell variable syntax in various weird little ways)
There was a problem hiding this comment.
that's fair, they are identical here so no behaviour change either way
44cd5d7
make pkgdocsto ensure Roxygen docs are up to date before running pkgdown. Needed because Pkgdown works from existing Rd pages and does not check whether they're in sync with the source comments.docs/folder from the list of files considered when checking ifdocument,test,check, orinstallneed to run. Otherwise running pkgdown immediately marks everything as needing redocumentation, reinstallation, etc.lazy = TRUEin thepkgdown::build_site()call, to avoid recompiling pages that haven't changed since the last pkgdown run.known pkgdown issues not addressed here:
make pkgdocscurrently always rebuilds all package sites, which takes several minutes. It would be nice to refactor it to only update the packages that are out of date.