Move optional dependencies from Imports to Suggests in PEcAn.data.land (#3599)#3840
Merged
infotroph merged 3 commits intoMar 6, 2026
Conversation
mdietze
previously requested changes
Mar 3, 2026
mdietze
left a comment
mdietze
left a comment
Member
There was a problem hiding this comment.
Rethink where these checks are performed, fix PEcAn internal installs, and determine whether we can get by with just one package for the Dirlichet distribution (if we can, MCMCpack is the more common or the two)
omkarrr2533
force-pushed
the
fix/3599-move-optional-deps-to-suggests
branch
from
68cf89f to
5c194e0
Compare
Member
Author
|
Sir, I have also send you my GSOC proposal for the 3rd project "Increasing PEcAn Modularity" project . when you get a chance, could you take a look and share any feedback..? i know you're busy. Thanks! |
infotroph
requested changes
Mar 4, 2026
infotroph
left a comment
infotroph
left a comment
Member
There was a problem hiding this comment.
I'm excited to move all of these to Suggests! Thanks for identifying the packages to reclassify.
Before merging:
- I see a few more places to adjust placement within the function
- the proposed change in
extract_soil_gssurgoconflicts with another open PR and should likely be deferred - Please update the dependency list to reflect these package changes by running
./scripts/generate_dependencies.Rand committing the changes it creates (which should all be indocker/depends/pecan_package_dependencies.csv)
omkarrr2533
force-pushed
the
fix/3599-move-optional-deps-to-suggests
branch
from
5c194e0 to
3fe8164
Compare
Member
|
You now have a merge conflict in pecan_package_dependencies.csv, and from the (incorrect) structure of the changes in that file it looks like you did not use |
…anProject#3599) Moved doSNOW, dplR, httr, MCMCpack, mvtnorm, neonUtilities, neonstore, PEcAn.benchmark, PEcAn.visualization, rjags, sirt, and sp from Imports to Suggests. Added requireNamespace() guards in all affected R files. Updated NEWS.md, CHANGELOG.md, and CITATION.cff.
omkarrr2533
force-pushed
the
fix/3599-move-optional-deps-to-suggests
branch
from
65e70a4 to
b2e6732
Compare
Member
Author
|
Done |
infotroph
approved these changes
Mar 5, 2026
Merged
via the queue into
PecanProject:develop
with commit Mar 6, 2026
550a17b
19 of 25 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3599
Moves 12 packages that are only needed for specific, optional functionality
from
ImportstoSuggestsinPEcAn.data.land.Packages moved from Imports to Suggests
doSNOWsoil_params_ensemble.RdplRmatchInventoryRings.R,Read_Tuscon.RhttrgSSURGO_Query.RMCMCpacksoil_params_ensemble.Rmvtnormplot2AGB.Rrmvnorm()callneonUtilitiesdownload_NEON_soilmoisture.Rneonstoreextract_NEON_veg.RPEcAn.benchmarkload_veg.Rload_data()callPEcAn.visualizationInventoryGrowthFusionDiagnostics.RciEnvelope()rjagsInventoryGrowthFusion.Rsirtextract_soil_nc.Rspextract_SM_CDS.R,IC_BADM_Utilities.RsfChanges made
DESCRIPTION: moved all 12 packages fromImportstoSuggestsrequireNamespace()guards with informativelogger.severe()messages in all affected R filesNEWS.md,CHANGELOG.md, andCITATION.cffTesting
Select-StringImports