Skip to content

fix(relationship-tracker): 0.6.3 match the built-in Tracker Panel sections - #1248

Merged
SpicyMarinara merged 1 commit into
Pasta-Devs:stagingfrom
NoblezDomain:fix/relationship-tracker-0.6.3
Oct 6, 2026
Merged

SpicyMarinara merged 1 commit into
Pasta-Devs:stagingfrom
NoblezDomain:fix/relationship-tracker-0.6.3

Conversation

@NoblezDomain

@NoblezDomain NoblezDomain commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Pull request

Important

Contributions target staging. Only SpicyMarinara may promote this repository's staging branch to main.
Outside and first-time contributors also require an approving review from SpicyMarinara.

Linked issue

Closes #1247

Why this change

  • A user reported on Discord (Engine 2.5.0) that Relationship Tracker looks out of place in the Tracker Panel: it draws its own card with a large "Relationship Tracker" title, while World, Persona, Present Characters, Inventory and Quartermaster use the shared collapsible header. It missed the unified tracker UI pass because the package was not in the catalog yet.
  • That pass (139e481 here, Marinara-Engine #5509) moved Memory Nag and Beholder to the built-in section look, and Quartermaster copies the same header. This PR brings Relationship Tracker in line, inside the package only.

What changed

  • relationship-tracker 0.6.2 → 0.6.3 (patch; CHANGELOG entry without a highlight).
  • Tracker Panel: the section uses the same header as the Engine's SectionHeader (chevron, icon, uppercase title, with the same spacing, divider and constrained-width text scale) and no longer draws its own card; the host's section shell supplies the background and divider. It collapses like the built-in sections, remembers that across reloads (localStorage key marinara.relationship-tracker.trackerPanelCollapsed), and toggles in place, so unsaved editor text survives. While the tracker runs, the header shows a small spinner where the built-in rows spin their re-run icon.
  • Desktop Trackers window (Tracker Panel off): the host drawer already shows the title and arrow, so the package leaves its header out when it sits inside .mari-drawer__body, a documented theming hook.
  • Toolbar tile: it uses the host's toolbarButtonClass, as Quartermaster, Beholder and Memory Nag do, instead of a self-styled ↔. It is slotted into light DOM so the host classes apply, has no action of its own, and lets presses through, so in the Trackers window a press opens the drawer like the built-in previews. Engines that pass no class get the previous self-styled mark, now with the same icon.
  • Package README: one line about the collapsible section.
  • Generated: artifacts/relationship-tracker-0.6.3.zip (206,379 bytes, SHA-256 5e3d6fd318bfbd8c360c96857a5ecc1b596bf1630768789bfa45e06eb82796a0), plus this package's entry and release notes in the published v2/v3 lanes and the legacy alias. No other package or catalog entry changes; the preview overlay is untouched.

Package and security impact

  • Affected package IDs: relationship-tracker
  • Engine compatibility impact: none. Engine 2.4.4 inclusive to <4.0.0 and Capability API 1.14 are unchanged. No Engine changes are required.
  • New or changed permissions/entrypoints: none. Only client.js changes, and it makes no new requests. The only new storage is the one localStorage key for the collapsed state.
  • Restart, storage, update, or uninstall impact: none beyond a normal package update. Card state v1, persona state v1, routes and the public read API are unchanged.

Validation

  • node scripts/validate-catalog.mjs passes locally
  • git diff --check passes locally
  • Rebuilt every affected manifest, payload, artifact, and catalog entry
  • Installed or updated the affected package through Marinara Engine
  • Checked supported modes, restart behavior, and uninstall cleanup
  • Read and followed CONTRIBUTING.md

Manual verification notes

  • Automated checks run on my machine with Claude Code: npm run check (0 errors; its 809 warnings are already on staging and none are in this package), node scripts/test-catalog-lanes.mjs, node scripts/validate-package-locales.mjs, node scripts/validate-catalog.mjs, node scripts/tests/catalog-release-notes.regression.mjs, and git diff --check all pass. A second run of node scripts/build-relationship-tracker-package.mjs produces no changes.
  • Package test suite (kept in the package's source tree): 172/172 pass, including 6 new regressions for the header, the remembered collapse (also with blocked storage), the Trackers-window drawer, the header spinner and the toolbar tile.
  • Visual check on a local page that loads the Engine 2.5.0 compiled CSS and the Tracker Panel's own section markup: the header measures the same as the built-in World row (padding, divider color, title size, weight, letter spacing and color, chevron and icon positions, corner radius). Collapse, expand, persistence across a reload, the Trackers-window drawer and the toolbar tile were exercised there.
  • Not done: the package was not installed or updated through Marinara Engine, and was not tried on a phone or touch device. Maintainers agreed to land it on staging for testing.

Documentation impact

  • No documentation changes needed
  • Updated this README catalog and package guidance
  • Updated linked Marinara Engine documentation

UI evidence (if applicable)

Screenshots from the local harness attached: before vs after in the Tracker Panel, the collapsed row beside the built-in trackers, and the Trackers window with the new toolbar tile.

image image image

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Relationship Tracker 0.6.3 adds a collapsible panel header that remembers its state and displays a spinner while running.
    • In the desktop Trackers window, the tracker uses the standard drawer header and matching button styling.

…tions

Marinara's August UI pass (139e481 here, Engine #5509) gave package
tracker sections the same collapsible header as the built-in trackers.
Relationship Tracker joined the catalog later, so it still drew its own
card with a large title, which a user reported on Engine 2.5.0.

- Tracker Panel: the section uses the built-in header (chevron, icon,
  uppercase title), drops its own card, remembers being collapsed, and
  shows a spinner while the tracker runs. Collapsing does not re-render,
  so unsaved editor text survives.
- Desktop Trackers window: the host drawer already shows the title and
  arrow, so the package header is left out there.
- The toolbar tile wears the host's toolbarButtonClass like Quartermaster,
  Beholder and Memory Nag; presses pass through to the drawer header.

Runtime payloads come from the Relationship Tracker source tree, where
172 regression tests pass. No Marinara Engine changes; the Engine range
and Capability API are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added bugfix Bug fix docs packages Agent package sources and manifests artifacts Generated downloadable package artifacts catalog Official catalog and package schemas labels Oct 6, 2026
@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: Pasta-Devs/Marinara-Agents/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 49777362-ba5b-4cb6-8234-dd3ae5b54157
📥 Commits

Reviewing files that changed from the base of the PR and between 5014699 and 4e45189.

⛔ Files ignored due to path filters (2)
  • artifacts/relationship-tracker-0.6.3.zip is excluded by !**/*.zip, !artifacts/**
  • packages/relationship-tracker/client.js is excluded by !packages/**/client.js
📒 Files selected for processing (9)
  • catalog/catalog.json
  • catalog/notes.json
  • catalog/v2/catalog.json
  • catalog/v2/notes.json
  • catalog/v3/catalog.json
  • catalog/v3/notes.json
  • packages/relationship-tracker/CHANGELOG.md
  • packages/relationship-tracker/README.md
  • packages/relationship-tracker/manifest.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Relationship Tracker is updated to version 0.6.3. Package and catalog metadata record the updated client and archive details. Release notes describe Tracker Panel collapse behavior and desktop Trackers window UI changes.

Changes

Relationship Tracker release

Layer / File(s) Summary
Package version and release notes
packages/relationship-tracker/manifest.json, packages/relationship-tracker/CHANGELOG.md, packages/relationship-tracker/README.md, catalog/notes.json, catalog/v2/notes.json, catalog/v3/notes.json
The package manifest records version 0.6.3 and the updated client metadata. The README and release notes describe the collapsible Tracker Panel, remembered collapse state, running spinner, and desktop Trackers window header and button changes.
Catalog package artifacts
catalog/catalog.json, catalog/v2/catalog.json, catalog/v3/catalog.json
The catalog entries record version 0.6.3, updated client checksums and sizes, and the 0.6.3 archive URLs and metadata.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 4e451

The 0.6.3 release records are consistent and no actionable merge risk remains. Proceed with normal staging checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the Relationship Tracker update and its main purpose: matching the built-in Tracker Panel sections.
Description check ✅ Passed The description covers the required sections, links issue #1247, identifies the affected package and impacts, reports validation and testing limits, documents the README change, and includes UI eviden…
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@SpicyMarinara SpicyMarinara left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@SpicyMarinara SpicyMarinara self-assigned this Oct 6, 2026
@SpicyMarinara
SpicyMarinara merged commit 474b380 into Pasta-Devs:staging Oct 6, 2026
20 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

artifacts Generated downloadable package artifacts bugfix Bug fix catalog Official catalog and package schemas docs packages Agent package sources and manifests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants