Fix attachment merging - #1498
Merged
Merged
Conversation
Allow auto-merging attachments with the same external path (if they have one), disregarding the internal path. Until now, if there is a part with attachments from an info provider and you chose to download them, when you update the part from the info provider these attachmets get duplicated and you can't save unless you delete the duplicates by hand.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1498 +/- ##
============================================
- Coverage 59.77% 59.76% -0.01%
- Complexity 9103 9104 +1
============================================
Files 679 679
Lines 29618 29621 +3
============================================
- Hits 17703 17702 -1
- Misses 11915 11919 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Seems useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow auto-merging attachments with the same external path (if they have one), disregarding the internal path.
Until now, if there is a part with attachments from an info provider and you chose to download them, when you update the part from the info provider these attachmets get duplicated and you can't save unless you delete the duplicates by hand.